New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove newline delimiter in UserServiceInformation output #148

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@raidan2
Contributor

raidan2 commented Jul 27, 2016

I'm not sure if we should ever add new line separator into 'toString' output.

You cannot simple check those logs with 'grep' if your operation has been separated on multiple lines:

[2016-07-27 10:33:37] 4742 [Mtp3-DeliveryExecutor-1-2-1] INFO  c.f.f.c.FusionCAPServiceListener - #onCAPMessage, capMessage = InitialDPRequestIndication [InvokeId=0, serviceKey=1, callingPartyNumber=CallingPartyNumberCap [data=[XXX ], CallingPartyNumber [numberingPlanIndicator=1, numberIncompleteIndicator=0, addressRepresentationREstrictedIndicator=0, screeningIndicator=3, natureOfAddresIndicator=3, oddFlag=0, address=XXXX11]], callingPartysCategory=CallingPartysCategoryInap [data=[10, ], CallingPartyCategory [callingPartyCategory=10]], locationNumber=LocationNumberCap [data=[XXX, ], LocationNumber [numberingPlanIndicator=1, internalNetworkNumberIndicator=0, addressRepresentationRestrictedIndicator=0, screeningIndicator=3, natureOfAddresIndicator=4, oddFlag=1, address=7]], bearerCapability=BearerCap [bearerCap=BearerCap [data=[XXX, ], UserServiceInformation [codingStandart=0, informationTransferCapability=0, transferMode=0, informationTransferRate=16, customInformationTransferRate=0,
l1UserInformation=3, syncMode=0, negotiation=0, userRate=0, intermediateRate=0, nicOnTx=0, fcOnTx=0, hdr=0, multiframe=0, mode=0, lli=0, assignor=0, inBandNegotiation=0, stopBits=0, dataBits=0, parity=0, duplexMode=0, modemType=0]]], eventTypeBCSM=collectedInfo, imsi=IMSI [XXX], locationInformation=LocationInformation [, ageOfLocationInformation=0, vlrNumber=ISDNAddressString[AddressNature=international_number, NumberingPlan=ISDN, Address=XXX01], cellGlobalIdOrServiceAreaIdOrLAI=[CellGlobalIdOrServiceAreaIdOrLAI [CellGlobalIdOrServiceAreaIdFixedLength [MCC=XXX, MNC=XX, Lac=XXXXX, CellId(SAC)=XXXXX]]]], extBasicServiceCode=ExtBasicServiceCode [ExtTeleserviceCode [Value=telephony, Data=[17, ]]], callReferenceNumber=CallReferenceNumber [Data= XXX], mscAddress=ISDNAddressString[AddressNature=international_number, NumberingPlan=ISDN, Address=XXX01], calledPartyBCDNumber=CalledPartyBCDNumber [addressNature=international_number, numberingPlan=ISDN, address=XXX91], timeAndTimezone=TimeAndTimezone [year=2016, month=7, day=13, hour=14, minite=10, second=6, timeZone=12]] 

@deruelle deruelle added this to the 7.1.0 milestone Jul 27, 2016

@vetss

This comment has been minimized.

Collaborator

vetss commented Aug 2, 2016

I have added your commit. Thanks.

@vetss vetss closed this Aug 2, 2016

@deruelle deruelle removed the Peer Review label Aug 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment