New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Issue #224 SCCP Routing based on calling party #230

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@faizann
Contributor

faizann commented Apr 21, 2017

Fixes issu224 SCCP Routing based on callingGT
Added code for using callingparty as secondary match when available in the routing. Also fixed bugs in modify/addrule in sccpexecutor and routerimpl. jss7-management-console work is in progress.
CallingParty rule is used as secondary rule for sorting the rules when CalledRule is same for multiple rules. This allows better control on routing.
CallingParty rule only matches SSN and GT TYPE and GT digits. It doesn't have mask as address overridden is done via new calling-party address id.

sccp rule create <id> <mask> <address-indicator> <point-code> <subsystem-number> <translation-type> <numbering-plan><nature-of-address-indicator> <digits> <ruleType> <primary-address-id> backup-addressid <backup-address-id> loadsharing-algo <loadsharing-algorithm> newcgparty-addressid <new-callingPartyAddress-id> origination-type <originationType> networkid <network-id> calling-ai <address-indicator> calling-pc <point-code> calling-ssn <calling-subsystem-number> calling-tt <calling-translation-type> calling-np <calling-numbering-plan> calling-nai <calling-nature-of-address-indicator> calling-digits <calling-digits> stackname <stack-name>

Added code for tests to compile.Tests are still failing
Fixed unit tests for serialization and cli/jmx creating/modifying of rules

All original tests passing successfully for SCCP. Calling address matching tests WIP

Added testOrderingByCallingAddress and removed callingPattern Mask

Fixed rule modification bug. Fixed length check in rule creation as it was missing networkid in the count. Fixed modifyrule bug where callingaddress was set as * by default

@deruelle deruelle requested a review from vetss Apr 22, 2017

@faizann faizann changed the title from Added code for tests to compile.Tests are still failing to Fixes Issue #224 SCCP Routing based on calling party Apr 24, 2017

@vetss

This comment has been minimized.

Collaborator

vetss commented Apr 28, 2017

Hello @faizann

is your work completely done or you still need to finish some issues ?
I am asking because you mentioned that "Tests are still failing". Please let me know.

@faizann

This comment has been minimized.

Contributor

faizann commented May 2, 2017

Hi

The comment about test failing came from a squashed merge. The code is complete as to CLI + SCCP routing. The GUI is not done in this one as I wanted to be sure about the rest of the part before I handle the GUI.

Faizan Naqvi
Added more unit tests for callingAddress rule matching/adding and cha…
…nged parameter name to calling-digits-pattern from calling-digits. Updated text documentation

@vetss vetss modified the milestones: 7.3.0, 8.0.0 May 4, 2017

@vetss

This comment has been minimized.

Collaborator

vetss commented May 4, 2017

Hello @faizann

I have added your commints, please check my comment in #224

@vetss vetss closed this May 4, 2017

@deruelle deruelle removed the Peer Review label May 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment