New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sccp conn establishment, release, reset with fixes #252

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@vmykhailiuk
Collaborator

vmykhailiuk commented Jul 21, 2017

No description provided.

@vetss

This comment has been minimized.

Collaborator

vetss commented Jul 21, 2017

@vmykhailiuk

I am getting confusing in your PRs...
which one should I use ? (This PR is also based on master branch)

@vmykhailiuk

This comment has been minimized.

Collaborator

vmykhailiuk commented Jul 21, 2017

@vetss
Creating pull request based on sccp-co branch won't help much because Github will display "Can’t automatically merge.". Most likely it's because sccp-co was created by cherry-picking commits from sccp-conn-establishment-release-#242 branch. I also answered in #251 with exact list of commands which will load latest changes to sccp-co branch.

Actually I'm slightly confused too. :) Now it's so much harder than when we had just a master branch, one pull-request with 1 or 2 commits to merge and new pull request was created only after previous one was merged. Also all discussion was in the issue #242. Having most of the changes in connection class and keeping routing and stack methods changes at minimum should help with avoiding introducing bugs to connectionless protocol classes implementation.

@vetss

This comment has been minimized.

Collaborator

vetss commented Jul 21, 2017

@vmykhailiuk

may be you can provide some branch in your repo that contains your commits (and give me a commit list) so I can add them into "sccp-co" branch and then you will be able synch to it. Is it possible ?

@vetss vetss closed this Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment