New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE with ICE. #320

Closed
leftyb opened this Issue Dec 20, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@leftyb

leftyb commented Dec 20, 2016

Not a webrtc call.
User-Agent: Linphone/3.7.0 (belle-sip/1.3.0)
Logs here: https://app.box.com/files/0/f/14805827043/RMS_ICE_NPE2-_12_2016

@hrosa

This comment has been minimized.

Collaborator

hrosa commented Dec 20, 2016

that’s because stun packet is empty, contains no attributes whatsoever.
In this case the user name attribute is empty and RMS needs it for message integrity verification.

Malformed packet is:
149998 14:33:33.681 116.100.65.68 7078 10.0.0.5 65192 STUN 64 Binding Request

https://tools.ietf.org/html/rfc5389#section-15.3

Still, we need to protect RMS against NPEs and send proper response back.

https://tools.ietf.org/html/rfc5389#section-7.3.1.1

@hrosa hrosa added this to the 5.2.0 milestone Dec 20, 2016

@hrosa hrosa added the Low-Priority label Jan 24, 2017

@hrosa hrosa removed this from the 5.2.0 milestone Jan 24, 2017

@deruelle deruelle added this to the 5.2.0 milestone Feb 7, 2017

@hrosa

This comment has been minimized.

Collaborator

hrosa commented Feb 13, 2017

@hrosa hrosa modified the milestones: 5.2.0, 6.0.0 Feb 14, 2017

@hrosa hrosa closed this in ec4c81e Feb 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment