Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
#476 Make MGCP channel buffer size configurable. #700
Hi @ibrarahmad thanks for the contribution, requested some very small changes.
As part of the ticket, the documentation must be updated to include explanation about the new parameter: https://github.com/RestComm/mediaserver/blob/master/docs/sources-asciidoc/src/main/asciidoc/concept-chapter-Configuring_the_Media_Server.adoc#controller-configuration
Also, we have a small set of scripts for automatic configuration that must be updated as well, to include support for new parameter.
Then implement method to persist the config here:
Finally, make sure that the changes you introduce as part of your development work are reflected in a test case. You can update this test case:
I think that is all. Once again, many thanks!
Thanks Henrique for you supported, I choose this, just to familiarized my self with the code base and the process of contribution.…
On Tue, Dec 19, 2017 at 10:37 PM, Henrique Rosa ***@***.***> wrote: Congrats @ibrarahmad <https://github.com/ibrarahmad> on your first contribution to MS :) Good job! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#700 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADbS8vo70WegQx_lW59kDazwggo-3yo1ks5tB_RwgaJpZM4QsLyF> .
-- Ibrar Ahmed EnterpriseDB http://www.enterprisedb.com