New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media server docker container #1

Merged
merged 1 commit into from Apr 19, 2016

Conversation

Projects
None yet
3 participants
@hamsterksu
Collaborator

hamsterksu commented Apr 11, 2016

@deruelle the first version of container

@deruelle

This comment has been minimized.

Member

deruelle commented Apr 11, 2016

Thanks @hamsterksu !
@hrosa @leftyb can you please review ?

Dockerfile Outdated
@@ -0,0 +1,25 @@
FROM java:8-jdk

This comment has been minimized.

@hrosa

hrosa Apr 13, 2016

Contributor

Official supported version is 7

mv /tmp/media-version.txt $work_dir
ADD scripts/configure.sh $work_dir
ADD scripts/run.sh $work_dir

This comment has been minimized.

@hrosa

hrosa Apr 13, 2016

Contributor

Are these auto-configures scripts that you created? Similar to the ones we have for RestComm?
If so, they should be included with the binary instead.

This comment has been minimized.

@hamsterksu

hamsterksu Apr 13, 2016

Collaborator

i have created it. names are similar.

@hrosa

This comment has been minimized.

Contributor

hrosa commented Apr 13, 2016

@hamsterksu @deruelle commented inline in the commit

@hamsterksu hamsterksu force-pushed the hamsterksu:dev branch from b5755f8 to 08a857e Apr 14, 2016

@hamsterksu

This comment has been minimized.

Collaborator

hamsterksu commented Apr 14, 2016

@hrosa i have updated java version.

@hamsterksu hamsterksu force-pushed the hamsterksu:dev branch from 08a857e to 2415a30 Apr 17, 2016

@hamsterksu hamsterksu force-pushed the hamsterksu:dev branch from 2415a30 to 1871742 Apr 18, 2016

@hrosa hrosa merged commit 7eac950 into RestComm:master Apr 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment