New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch accounts,application #3

Merged
merged 26 commits into from Jun 23, 2017

Conversation

Projects
None yet
2 participants
@mithileshkarnati
Contributor

mithileshkarnati commented Jun 16, 2017

I have added Accounts and Applications Modules
Only thing missing is AsciiDocs

@mithileshkarnati

This comment has been minimized.

Contributor

mithileshkarnati commented Jun 19, 2017

I have also added ASCII Documentation for the Accounts module

@gvagenas

This comment has been minimized.

Contributor

gvagenas commented Jun 22, 2017

Great job @mithileshkarnati . Only one issue, please provide proper package name for the classes in the test folder.
PR is ready to merge after this minor fix.

Also please, create issues for the missing parts. Next PRs will have to be tied to the issue it will resolve.

@gvagenas

This comment has been minimized.

Contributor

gvagenas commented Jun 22, 2017

Also provide README.md with the following:

  • Give a short description of the project (1-2 lines)
  • how to build the project
  • how to run the tests
  • Java version supported
  • Reference any dependencies that might be needed to be added by a developer
  • Provide instructions for where to download Restcomm and point to the restcomm documentation site
  • Provide information how and where developers can open issues and feature requests

Also please provide example application and instructions for how to run it etc.

Imagine you have a Java developer but not familiar with Restcomm-Connect, that wants to use the library. Given that, we must provide any necessary information for him to get started.

@gvagenas gvagenas merged commit fcc2c92 into RestComm:master Jun 23, 2017

@gvagenas

This comment has been minimized.

Contributor

gvagenas commented Jun 23, 2017

Congrats @mithileshkarnati PR merged, great job 👍
Looking forward for the rest of the work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment