Duplicate Timeout Timer on RKRequest #517

Closed
hermanccw opened this Issue Jan 22, 2012 · 2 comments

Comments

Projects
None yet
3 participants
@hermanccw

Looks like a recent merge of RKRequest introduce this the following bug.

Repo step.

  1. create a RKRequest
  2. send asynchronously
  3. received result from server
  4. after the timeout period (default 120 sec), get notify from RestKit that a timeout has occurred.

I looked into the recent merge and it seems like that a NSTimer is created in sendAsynchronously before calling fireAsynchronousRequest which in itself create another NSTimer. Therefore, 2 timer is created even though we only need one. I commented out the first NSTimer creation (line 426 in RKRequest.m) and everything worked fine again.

@bmorton

This comment has been minimized.

Show comment
Hide comment
@bmorton

bmorton Jan 22, 2012

Contributor

Thanks for pointing this out. This was being discussed over on the google group as well. I'm committing a test and patch and am going to put in a pull request to fix this.

Contributor

bmorton commented Jan 22, 2012

Thanks for pointing this out. This was being discussed over on the google group as well. I'm committing a test and patch and am going to put in a pull request to fix this.

bmorton added a commit to bmorton/RestKit that referenced this issue Jan 22, 2012

@ghost ghost assigned endash Jan 23, 2012

@endash endash closed this in b0fd4d4 Jan 23, 2012

@endash

This comment has been minimized.

Show comment
Hide comment
@endash

endash Jan 23, 2012

Contributor

Fixed in development, will be merged to master soon.

Contributor

endash commented Jan 23, 2012

Fixed in development, will be merged to master soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment