Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Prevents deletion of managed objects if a response mapper error is encountered #1700

Merged
merged 3 commits into from Dec 4, 2013

Conversation

Projects
None yet
2 participants

Unit tests and fix for #1695

Konstantin Novikov added some commits Dec 4, 2013

@blakewatters blakewatters commented on an outdated diff Dec 4, 2013

Code/Network/RKManagedObjectRequestOperation.m
@@ -613,10 +613,13 @@ - (void)performMappingOnResponseWithCompletionBlock:(void(^)(RKMappingResult *ma
return completionBlock(nil, error);
}
}
-
- success = [weakSelf deleteLocalObjectsMissingFromMappingResult:mappingResult error:&error];
- if (! success || [weakSelf isCancelled]) {
- return completionBlock(nil, error);
+
+ if (!responseMappingError) {
+
@blakewatters

blakewatters Dec 4, 2013

Owner

Can you kill this extraneous whitespace please?

Owner

blakewatters commented Dec 4, 2013

Looks great other than the minor whitespace nit. Thanks!

Konstantin Novikov Remove extra whitespace b0ee437

@blakewatters blakewatters added a commit that referenced this pull request Dec 4, 2013

@blakewatters blakewatters Merge pull request #1700 from novkostya/bugfix/1695
Prevents deletion of managed objects if a response mapper error is encountered
d930d06

@blakewatters blakewatters merged commit d930d06 into RestKit:development Dec 4, 2013

1 check failed

default The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment