Using proper error field for warning #1799

Merged
merged 1 commit into from Feb 18, 2014

Conversation

Projects
None yet
3 participants
@yoiang
Contributor

yoiang commented Feb 18, 2014

No description provided.

@segiddins

This comment has been minimized.

Show comment Hide comment
@segiddins

segiddins Feb 18, 2014

Owner
Owner

segiddins commented Feb 18, 2014

@blakewatters

This comment has been minimized.

Show comment Hide comment
@blakewatters

blakewatters Feb 18, 2014

Owner

Looks good, waiting on Travis to finish

Owner

blakewatters commented Feb 18, 2014

Looks good, waiting on Travis to finish

@yoiang

This comment has been minimized.

Show comment Hide comment
@yoiang

yoiang Feb 18, 2014

Contributor

Thanks guys! In the future is there a format or process y'all prefer for contributions?

Contributor

yoiang commented Feb 18, 2014

Thanks guys! In the future is there a format or process y'all prefer for contributions?

@blakewatters

This comment has been minimized.

Show comment Hide comment
@blakewatters

blakewatters Feb 18, 2014

Owner

In general, there is a huge delta in how quickly a pull request is merged depending on if it includes test coverage. Otherwise we have to write it. Beyond that, just keeping things nice and atomic is the only other major point.

Extensive feature work should be discussed with us directly via an issue or email before a ton of engineering effort is expended.

Owner

blakewatters commented Feb 18, 2014

In general, there is a huge delta in how quickly a pull request is merged depending on if it includes test coverage. Otherwise we have to write it. Beyond that, just keeping things nice and atomic is the only other major point.

Extensive feature work should be discussed with us directly via an issue or email before a ton of engineering effort is expended.

blakewatters added a commit that referenced this pull request Feb 18, 2014

@blakewatters blakewatters merged commit 852ecee into RestKit:development Feb 18, 2014

1 check passed

default The Travis CI build passed
Details
@yoiang

This comment has been minimized.

Show comment Hide comment
@yoiang

yoiang Feb 18, 2014

Contributor

sounds good, thanks again

Contributor

yoiang commented Feb 18, 2014

sounds good, thanks again

@yoiang yoiang deleted the RyzacInc:FixUsingProperErrorField branch Feb 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment