Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

#84: OAuth support #211

Closed
wants to merge 27 commits into
from

Conversation

Projects
None yet
5 participants

Hi,
Just I had integrated the TDOAuth library into the RestKit framework project. I tried to keep as much possible the flow of the RKRequest flow and also I updated the RKTwitter example to explain how works the update. I would love to contribute and improve this code to the project.

A heads-up! The implementation of this pull is for OAuth1. Now I'm working to include OAuth2.

jk commented Jul 25, 2011

Can you give an overview of which draft you try to implement and which features from your point of view are still missing? I just came across your pull request and think about to merge it with my efforts to implement OAuth2 draft 15.

Hi Jk,
I just had implemented the support for OAuth 1 and I'm working in the integration for the whole process of OAuth 2 - Draft 11 with the device flow. If you want, we can work on team to try to integrate both pull :).

rod

jk commented Aug 17, 2011

Hi rodchile,

sorry for being so silent the last weeks. I patched the OAuth2-php implementation from Google Code to be working draft-20 implementation. Only bearer tokens are supported atm, perhaps I find the time to support MAC tokens as well. Now I'm back to Xcode and have to implement OAuth2 there. Hopefully we can achieve something here. I will look at your latest changes this evening or tomorrow.

Member

grgcombs commented Sep 13, 2011

@rodchile, a few notes I had on the pull request:

  1. There is a compiler warning in RKSpecEnvironment
  2. Can you do a rebase so that this becomes a fast-forward git operation?
  3. This may be related to the one above, but right now I get 36 failures when I run the UISpec target in Xcode (even after starting the spec server with rake 'uispec:server')
Member

grgcombs commented Sep 16, 2011

@rodchile, did you ever get in touch with @blakewatters? Like I said, I think we're fairly close, but it would make things go a lot faster with the merge if you did a rebase so that this becomes a fast-forward operation. Also, I know you were working with a couple of different branches ... master and reskit-update or something like that ... make sure that this pull request is for whichever branch you actually want merged.

Owner

blakewatters commented Sep 16, 2011

I'm headed back from NYC this afternoon and will come roaring back into action. Definitely want to get this merged on 0.9.4 out the door.

On Friday, September 16, 2011 at 11:18 AM, Greg Combs wrote:

@rodchile, did you ever get in touch with @blakewatters? Like I said, I think we're fairly close, but it would make things go a lot faster with the merge if you did a rebase so that this becomes a fast-forward operation. Also, I know you were working with a couple of different branches ... master and reskit-update or something like that ... make sure that this pull request is for whichever branch you actually want merged.

Reply to this email directly or view it on GitHub:
#211 (comment)

Sorry folks for the silence of this days. I merged the master branch of my fork with the latest changes on RestKit and is available already. I'm leaving today on holiday (we're celebration our independence day in Chile) and I'll be away until Monday.

@grgcombs do you want me to use rebase to push forward the commits of the functionality?

Member

grgcombs commented Sep 16, 2011

Uh, I don't understand your question. Rebasing is basically taking all of your changes and moving them forward (or even earlier) in time, to place them on top of another commit checkpoint. What we want to do is get your oauth changes placed on top of the current state of RestKit's main master branch, that way when we merge in your changes, we're moving forward in time and we're only changing a handful of files. So here's what we need to do...

  1. Merge all of your new stuff in "restkit-update" back over to your master branch, because your "master" is the branch your pull request was issued from.
  2. Now run git rebase -i upstream/master to forward-port your local commits to the current upstream head …. this assumes you're using the command line, and that you call the main RestKit github repository account "upstream", but hopefully you get the picture … there is similar functionality in in a graphical git tool like SmartGit or Tower or whatever.

blakewatters added a commit that referenced this pull request Sep 20, 2011

Refactored OAuth support for merge into master. fixes #84, #211
Cleaned up @rodchile's excellent work integration OAuth 1.0 and 2.0 into RestKit. Changes
are as follows:

* Introduced new RKRequestAuthenticationType to replace the forceBasicAuthentication and other
    methods for influencing how authorization works.
* Moved TDOAuth code into Vendor/
* Renamed authorization code flow classes and delegate methods for clarity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment