Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that the entity description used is from the correct model #2139

Merged
merged 1 commit into from Jan 16, 2015

Conversation

sixten
Copy link
Contributor

@sixten sixten commented Jan 16, 2015

As reported in #2134, I've encountered a number of issues stemming from situations where the NSEntityDescription in the RKEntityMapping didn't come from the same copy of the model that's attached to the persistent store controller. Using the name from the mapping's entity works.

@segiddins
Copy link
Member

And those unit tests failed before your change?

@sixten
Copy link
Contributor Author

sixten commented Jan 16, 2015

Indeed. Should I separate that into two commits to make that easier to observe?

@segiddins
Copy link
Member

nope, just making sure :)

segiddins added a commit that referenced this pull request Jan 16, 2015
Make sure that the entity description used is from the correct model
@segiddins segiddins merged commit af46b15 into RestKit:master Jan 16, 2015
cfis pushed a commit to cfis/RestKit that referenced this pull request Jan 19, 2015
@sixten sixten deleted the entity-mismatch branch June 28, 2016 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants