Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Always call objectLoaderDidFinishLoading #721

wants to merge 1 commit into


None yet
2 participants

cfis commented May 7, 2012

As part of our RKObjectLoaderDelegate, we rely on objectLoaderDidFinishLoading to do some house cleaning. objectLoaderDidFinishLoading is called whether a request is a success or failure, except in one case. This commit fixes that case.

The case happens when a failure occurs in processMappingResult. On success, processMappingResult already indirectly calls objectLoaderDidFinishLoading. This patch simply also calls it when a failure occurs. The end result is that objectLoaderDidFinishLoading is always called.

Let me know if you have questions

Thanks - Charlie

Make sure that finalizeLoad is always called allowing delegates to do…
… any last minute house keeping at the end of a request.

blakewatters commented May 17, 2012

Thanks. Will add some test coverage and get this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment