New ES stable release

[joolswills]

Hi all - @jrassa @psyke83 @@tomaz82 et al

Anyone know any major issues on the trunk version? - It's been a long time since a stable release with new features etc, and there are a bunch of bug fixes on master.

If people think the current dev version is stable, I would be happy to update the stable branch,

[joolswills]

Apart from the broken scraper of course. I'm planning on disabling that (at least until we have a replacement using screenscraper or something).

[pjft]

I am not aware of any meaningful issues on the dev branch. There's a small issue with the upgrade path for the new audio settings which I'm not fully comfortable with - it can lead to a crash when in the menu - but other than that all good.

Edit: unless those are already on the stable branch:)

I do wonder: is it still useful to have the two branches?

Happy New Year everyone.

[joolswills]

Well, there was some major development before on master, which wasn't ready right away, so the stable branch is useful. I like having a stable branch so we don't have to worry too much if there is a bug with a new feature.

[joolswills]

There is this also 9ab5223 - which I did only on stable, but I think I may do that on master also, until there is a better solution as it's a big performance hit.

[cmitu]

I am planning to submit a patch for the scraper, enabling scraping from ScreenScraper.fr (https://github.com/cmitu/EmulationStation/tree/screenscraper).
The new addition works only master, since it uses some functions added after the Boost elimination, but can probably added to the stable with a few additions.
If you plan to change the stable branch, it would be helpful to merge the changes in the Utils namespace to it. Should I wait for the stable switch or should I submit the PR before ?

[joolswills]

Thanks. Please submit PR for master. I'll merge and update stable for a new release (I might do a couple of minor things also).

[cmitu]

@joolswills Done - #519.

[acrummyidea]

Over last weekend I have fixed the gamesdb scraper to use the new gamesdb api. I’ll create a PR.

[acrummyidea]

@joolswills Updated TheGamesDB scraper PR is in: #520

[5schatten]

@joolswills
I've tried #520 and LGTM. Scraping worked fine for my tested games (Doom/Doom2/Quake).

[acrummyidea]

@joolswills let me know if I can help in any way :)

[joolswills]

Testing es dev. Reproduced the crash in menu due to unset audio card. That definitely needs sorting. If unset we need to choose a default I guess. Not checked the code related to this.

[cmitu]

I can take a look. I guess the problem is caused by #460 ?

[pjft]

Yep. Happy to look into it either way, I suppose it's just a matter of, when losing the settings, if the value isn't recognized, selecting an appropriate new value for the pi (or the device).

[pjft]

I'll look into it tonight, likely.

[pjft]

#523 should actually do it.

[joolswills]

@tomaz82 I was thinking - rather than revert cd2f2ee would it be better to make it optional (but default to off). That way people can use it if they want. If so, what should the setting be called ? "Load matching art not in gamelist" ? hard to word this one.

maybe just "Search for local game art" ?

[joolswills]

eg -#526 - anyone have anything against this ?

[joolswills]

Stable branch is updated (to v2.8.0). Thanks all.

[5schatten]

can you tag the release?

[joolswills]

I will later. Just build from the stable branch for now.