Go-to Random Game feature #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks - if anyone has time to help me with testing would appreciate it cheers. |
|
Updated as per the feedback from the ever helpful @pjft,
|
|
Looks good to me. Tested, no concerns from my end. |
|
Thanks all. |
fabricecaruso
referenced
this pull request
in fabricecaruso/old-EmulationStation-fork---see-batocera-emulationstation-instead
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This is a PR to enable users to jump to a random game with the push of a button (currently: x). The idea is to get people to play games they would otherwise not consider playing, especially when they have a large collections of games to choose from.
The changes are relatively small, and tested on a test-collection with sub-folders.
I am unsure if recounting all the games every time this is called will take prohibitively long or not, so I would like to get some feedback on that, if possible. I've tried it with a setup with 20K (dummy) files for a system, and that had no discernable effect on performance. Note that this was on a windows machine, but I suspect it will not matter, as ES gets the info from it's internal data-structures (in RAM) anyways.
Let me know what you think!