New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "getThumbnailPath" ignoring the 'image' tag when 'LocalArt' is not set #528

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
3 participants
@cmitu
Copy link

cmitu commented Feb 12, 2019

This seems to fix the problems reported in the forum (https://retropie.org.uk/forum/topic/21216, https://retropie.org.uk/forum/topic/21227/ and I'm sure there's at least another one).
getThumbnailPath returns an empty string when LocalArt is not enabled and then the thumbnail tage is empty, but it should look at the image tag also, regardless of LocalArt setting.

I would appreciate some testing, I only tested this on Windows where I don't have videos.

@joolswills

This comment has been minimized.

Copy link
Member

joolswills commented Feb 12, 2019

Good catch. My fault for rushing that setting. Oops.

@joolswills joolswills merged commit bec9836 into RetroPie:master Feb 12, 2019

@joolswills

This comment has been minimized.

Copy link
Member

joolswills commented Feb 12, 2019

I've updated stable and am rebuilding binaries now. Should be available shortly.

@cmitu

This comment has been minimized.

Copy link
Author

cmitu commented Feb 12, 2019

Can you please leave a note in the forum when the binaries are available, so people can test it and confirm the fix.

There's a 2nd issue reported with a crash when the grid view is activated, but haven't had a chance to test it.

@joolswills

This comment has been minimized.

Copy link
Member

joolswills commented Feb 12, 2019

They should be available in 30 or so. I won't be around to check until later. You can check - version should be 2.8.1

@cmitu

This comment has been minimized.

Copy link
Author

cmitu commented Feb 12, 2019

You can check - version should be 2.8.1

Ah, forgot about the version bump. I'll add a note later, thanks.

@pjft

This comment has been minimized.

Copy link

pjft commented Feb 12, 2019

Ah, I take it this is related to the thread I just replied to?

@cmitu

This comment has been minimized.

Copy link
Author

cmitu commented Feb 12, 2019

@pjft - I pinged you in one of the topics where this was reported, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment