New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added lr-freechaf module #2534

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@recompileorg

recompileorg commented Nov 18, 2018

This is for the FreeChaF ChannelF libretro core

@joolswills

This comment has been minimized.

Member

joolswills commented Nov 19, 2018

Thanks. On phone so haven't tested. Looks generally ok but we will need a platforms.cfg entry. I will test and review asap.

@recompileorg

This comment has been minimized.

recompileorg commented Nov 22, 2018

Looks generally ok but we will need a platforms.cfg entry.

Something like this?

channelf_exts=".bin .rom"
channelf_fullname="Fairchild ChannelF"
channelf_platform="channelf"
@joolswills

This comment has been minimized.

Member

joolswills commented Nov 27, 2018

you don't need the channelf_platform="channelf" line. and .zip and .7z should also probably be included as extensions.

@recompileorg

This comment has been minimized.

recompileorg commented Dec 3, 2018

Thanks. I've added the entry to platforms.cfg with the changes you suggested.

@joolswills

This comment has been minimized.

Member

joolswills commented Dec 6, 2018

Sorry - you have included unrelated changes in platforms.cfg now.

I will add the module manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment