New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

steamlink: add overscan override #2552

Merged
merged 1 commit into from Dec 5, 2018

Conversation

Projects
None yet
4 participants
@psyke83
Contributor

psyke83 commented Dec 4, 2018

The steamlink client will refuse to launch when overscan is enabled
(which is enabled by default on our RetroPie image), but an override
is supported.

(they added this overscan detection to their scripts after I submitted the initial PR)

@CookiePLMonster

This comment has been minimized.

CookiePLMonster commented Dec 5, 2018

.deb file has updated to 1.0.5 too, btw. Maybe it'd be worth asking them nicely for a way to retrieve the latest .deb from a constant link, so setup script doesn't fall behind? They seem to be very responsive on that matter thus far.

EDIT:
I'm curious though, where does .ignore_overscan option come from? I can't find it documented anywhere.

@@ -33,4 +33,12 @@ function remove_steamlink() {
function configure_steamlink() {
addPort "$md_id" "steamlink" "Steam Link" "/usr/bin/steamlink"
# RetroPie sets overscan by default, which requires an override
if egrep '^overscan_scale=1' /boot/config.txt >/dev/null 2>&1; then

This comment has been minimized.

@joolswills

joolswills Dec 5, 2018

Member

I don't think grep -E is needed.

also &>/dev/null would be more concise in bash.

This comment has been minimized.

@hhromic

hhromic Dec 5, 2018

Contributor

even better: grep -q '^overscan_scale=1' /boot/config.txt doesn't produce output at all ;)

This comment has been minimized.

@joolswills

joolswills Dec 5, 2018

Member

it will if config.txt doesn't exist.

This comment has been minimized.

@hhromic

hhromic Dec 5, 2018

Contributor

right, sorry, I keep forgetting that RetroPie doesn't run only on RPIs :)

This comment has been minimized.

@joolswills

joolswills Dec 5, 2018

Member

This module is RPI only, but actually on a RPI config.txt may not be present. Boot partition may not be mounted or like with berryboot.

@psyke83 psyke83 force-pushed the psyke83:steamlink_overscan branch from 6b9425e to 3a75353 Dec 5, 2018

@joolswills

It may be required to create the .config and .local and .share also - I think I had to do that elsewhere if you grep the other modules. Your sudo solution was cleaner really but :-)

Maybe retro pie can ensure these exist in as multiple modules use them. I'll do that actually.

@psyke83

This comment has been minimized.

Contributor

psyke83 commented Dec 5, 2018

shakes fist

;)

I was following the example seen in steamcontroller.sh by creating a user spawned sudo shell, but I'm too lazy to check git blame on that part of the code to know if that code was you/sanctioned by you, haha.

steamlink: add overscan override & update to 1.0.5
The steamlink client will refuse to launch when overscan is enabled
(which is enabled by default on our RetroPie image), but an override
is supported.

Also expose streaming_args.txt as optional user configuration.

@psyke83 psyke83 force-pushed the psyke83:steamlink_overscan branch from 3a75353 to eb0d725 Dec 5, 2018

@joolswills joolswills merged commit 4a4e971 into RetroPie:master Dec 5, 2018

@joolswills

This comment has been minimized.

Member

joolswills commented Dec 5, 2018

thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment