New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addEmulator / Runcommand RetroArch commandline detection #2555

Merged
merged 2 commits into from Dec 8, 2018

Conversation

Projects
None yet
2 participants
@joolswills
Member

joolswills commented Dec 6, 2018

helpers / addEmulator - adjust the logic for automatic RA cmd generation

  • match against any cmd parameter that is an .so in $md_inst

runcommand - detect retroarch by emulator id not command string

@hhromic - hopefully this will help #2551

@joolswills

This comment has been minimized.

Member

joolswills commented Dec 6, 2018

I adjust the runcommand detection also so your script doesn't have to have retroarch in the name.

@joolswills joolswills changed the title from helpers / addEmulator - adjust the logic for automatic RA cmd generation to addEmulator / Runcommand RetroArch commandline detection Dec 6, 2018

@hhromic

This comment has been minimized.

Contributor

hhromic commented Dec 7, 2018

thanks for this @joolswills !
I tested it now and is working like a charm. I also was thinking on something similar for the addEmulator function, good to see you made it happen.
I also tested the runcommand changes and working as expected too. Very elegant solution, liked it.
I tested different LR emulators and also the proposed lr-scummvm emulator using the changes in this PR, everything is working good! The lr-scummvm looks way less hacky now.
You can merge this I think. Thanks for the useful changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment