New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

advmame, configedit - fix scriptmodule permissions (755 -> 644) #2558

Merged
merged 1 commit into from Dec 7, 2018

Conversation

Projects
None yet
2 participants
@hhromic
Contributor

hhromic commented Dec 7, 2018

I just noticed that the advmame and configedit scriptmodules are set to executables. Like all the other scriptmodules, these should also not be executables. Probably someone forgot to set them correctly.
This PR doesn't change any functionality or files, it just fixes the file permissions.

Found doing this:

$ find scriptmodules -maxdepth 2 -executable -type f
scriptmodules/supplementary/configedit.sh
scriptmodules/emulators/advmame.sh
advmame, configedit - fix scriptmodule permissions (755 -> 644)
These scriptmodules should not be executable.

@joolswills joolswills merged commit 87773ed into RetroPie:master Dec 7, 2018

@joolswills

This comment has been minimized.

Member

joolswills commented Dec 7, 2018

Thanks

@hhromic hhromic deleted the hhromic:fix-permissions branch Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment