Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lr-snes9x - update and simplify scriptmodule #2681

Merged
merged 1 commit into from Apr 15, 2019

Conversation

Projects
None yet
2 participants
@hhromic
Copy link
Contributor

commented Apr 15, 2019

  • using platform=armv is now sufficient for the build to use -DARM
  • adding neon to platform has no effect on the built binary of this core
    • there is no NEON-specific code in the core
  • also pass platform parameter for the clean target as well (I know you plan to remove cleaning during build, but for now at least let's keep it consistent)

Currently, -DARM is repeated twice because of the workaround in the scriptmodule:

g++ -I../libretro -I.. -I../apu/ -I../apu/bapu   -O2 -march=armv8-a+crc -mtune=cortex-a53 -mfpu=neon-fp-armv8 -mfloat-abi=hard -ftree-vectorize -funsafe-math-optimizations -DARM -DGIT_VERSION=\"" dad0ae5"\" -flto -DARM -O3 -DNDEBUG -fomit-frame-pointer -Wall -W -Wno-unused-parameter -fPIC -DRIGHTSHIFT_IS_SAR -D__LIBRETRO__ -DALLOW_CPU_OVERCLOCK -DHAVE_STDINT_H -DHAVE_STRINGS_H -fno-rtti -pedantic  -fno-exceptions -c -o../apu/bapu/smp/smp.o ../apu/bapu/smp/smp.cpp

Without the workaround, -DARM is still added properly with current upstream:

g++ -I../libretro -I.. -I../apu/ -I../apu/bapu   -O2 -march=armv8-a+crc -mtune=cortex-a53 -mfpu=neon-fp-armv8 -mfloat-abi=hard -ftree-vectorize -funsafe-math-optimizations -DGIT_VERSION=\"" dad0ae5"\" -flto -DARM -O3 -DNDEBUG -fomit-frame-pointer -Wall -W -Wno-unused-parameter -fPIC -DRIGHTSHIFT_IS_SAR -D__LIBRETRO__ -DALLOW_CPU_OVERCLOCK -DHAVE_STDINT_H -DHAVE_STRINGS_H -fno-rtti -pedantic  -fno-exceptions -c -o../apu/bapu/smp/smp.o ../apu/bapu/smp/smp.cpp

Build and games tested on Raspberry Pi 3 using __platform=rpi1, __platform=rpi2, __platform=rpi3.

Edit: to confirm the same binary, I compared the checksums of the core built before and after this PR:

53d27f3a1ab9b62000e33dd20c24e773  snes9x_libretro.so.before
53d27f3a1ab9b62000e33dd20c24e773  snes9x_libretro.so.after
lr-snes9x - update and simplify scriptmodule
* using `platform=armv` is now sufficient for the build to use `-DARM`
  - fixed since a while here: libretro/snes9x#62
* adding `neon` to `platform` has no effect on the built binary of this core
  - there is no NEON-specific code in the core
* also pass `platform` parameter for the clean target as well

@joolswills joolswills merged commit d35e619 into RetroPie:master Apr 15, 2019

@joolswills

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

thanks.

@hhromic hhromic deleted the hhromic:update-lr-snes9x branch Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.