Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dxx-rebirth: update for fkms and buster #2766

Merged
merged 1 commit into from Jul 8, 2019

Conversation

Projects
None yet
3 participants
@psyke83
Copy link
Member

commented Jul 7, 2019

  • Update dependencies
  • Enable OpenGL + SDL2 build for non-gles targets
  • Enable fkms/mesa target, also using SDL2+GL (due to upstream
    source requiring changes to support GLESv2 builds)

@psyke83 psyke83 force-pushed the psyke83:dxx_fkms branch from 71bed87 to 97531af Jul 7, 2019

@psyke83

This comment has been minimized.

Copy link
Member Author

commented Jul 7, 2019

Tested on RPI3/fkms + buster. In GL+SDL2 mode, the D1+2 appears to run at a perfectly smooth 60fps.

My changes to enable mesa support were accepted upstream some time ago, but it doesn't works as expected for buster due to the dependency on GLESv1 functions. Until that's fixed, the SDL2+GL is working very well (and may be more desirable, as SDL2 cannot be enabled for GLES builds).


function depends_dxx-rebirth() {
local depends=(libphysfs1 libphysfs-dev libsdl1.2-dev libsdl-mixer1.2-dev scons)
isPlatform "rpi" && depends+=(libraspberrypi-dev)
local depends=(libpng-dev libphysfs1 libphysfs-dev libsdl1.2-dev libsdl-mixer1.2-dev scons)

This comment has been minimized.

Copy link
@hhromic

hhromic Jul 7, 2019

Contributor

I remember @joolswills asking to not include library packages in the dependencies but intsead the -dev packages of them. In this case libphysfs1 should be removed in favour of the existing and correct libphysfs-dev. Of course this is not your fault in this PR and seems to be vestigial from older code but now that you are on it, why not amend it? :)

This comment has been minimized.

Copy link
@psyke83

psyke83 Jul 7, 2019

Author Member

I've updated the patch to do this - thanks for spotting.

I've also changed the build configuration to specify words_need_alignment=1 for all arm targets. This is already enabled when raspberrypi is selected, but I'm guessing it might be needed for other generic arm boards too.

dxx-rebirth: update for fkms and buster
* Update dependencies
* Enable OpenGL + SDL2 build for non-gles targets
* Enable fkms/mesa target, also using SDL2+GL (due to upstream
  source requiring changes to support GLESv2 builds)

@psyke83 psyke83 force-pushed the psyke83:dxx_fkms branch from 97531af to 5ab01f5 Jul 7, 2019

@joolswills joolswills merged commit 77f2d29 into RetroPie:master Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.