Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lr-parallel-64 - fix building on rpi4/kms #2887

Merged
merged 1 commit into from Dec 2, 2019

Conversation

@joolswills
Copy link
Member

joolswills commented Nov 1, 2019

  • remove a typedef conflict - may need to upstream a proper fix for this
  • change logic from "tinker" to "kms" for make parameters to make it more general
  • rollback code for "neon" rather than "arm" platforms

I've not tested this at all apart from building on rpi2 and rpi4. Need to check the typedef change on tinkerboard. Probably should be upstreamed but upstream master is broken on arm which also needs fixing.

@joolswills

This comment has been minimized.

Copy link
Member Author

joolswills commented Nov 1, 2019

To clarify. HEAD doesn't build on arm due to some makefile changes or so. Fails at linking stage.

libretro/parallel-n64#544

Probably a simple fix.

@joolswills joolswills force-pushed the joolswills:lr-parallel-n64_fix branch from 20e120d to 980ae11 Nov 1, 2019
@joolswills joolswills changed the title DONOTMERGE lr-parallel-64 - fix building on rpi4/kms Lr-parallel-64 - fix building on rpi4/kms Nov 10, 2019
@joolswills joolswills added the fkms label Nov 10, 2019
if isPlatform "rpi" || isPlatform "odroid-c1"; then
params+=(platform="$__platform")
elif isPlatform "tinker"; then
if isPlatform "kms"; then

This comment has been minimized.

Copy link
@psyke83

psyke83 Nov 11, 2019

Member

Can you change this to mesa, please?

IMHO, usage of the kms platform flag should be architecture-agnostic when possible due to the fact that any modern system is potentially capable of running in KMS mode. Your PR runs fine on x86 kms mode with the flag changed to mesa (whereas the PR breaks the x86 kms build as-is). Thanks.

This comment has been minimized.

Copy link
@joolswills

joolswills Nov 12, 2019

Author Member

Thanks. Will do.

@joolswills joolswills force-pushed the joolswills:lr-parallel-n64_fix branch 4 times, most recently from c186d53 to b943229 Nov 21, 2019
 * added libgles2-mesa-dev dependency for kms+gles platforms
 * remove a typedef conflict - may need to upstream a proper fix for this
 * rework Makefile parameter logic based on our platform flags
@joolswills joolswills force-pushed the joolswills:lr-parallel-n64_fix branch from b943229 to 8ffd03e Nov 21, 2019
@joolswills

This comment has been minimized.

Copy link
Member Author

joolswills commented Dec 2, 2019

Merging but this may need further platform logic tweaks.

@joolswills joolswills merged commit 3892d5b into RetroPie:fkms_rpi4 Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.