Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upLr-parallel-64 - fix building on rpi4/kms #2887
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
To clarify. HEAD doesn't build on arm due to some makefile changes or so. Fails at linking stage. Probably a simple fix. |
joolswills
force-pushed the
joolswills:lr-parallel-n64_fix
branch
from
20e120d
to
980ae11
joolswills
changed the title
| if isPlatform "rpi" || isPlatform "odroid-c1"; then | ||
| params+=(platform="$__platform") | ||
| elif isPlatform "tinker"; then | ||
| if isPlatform "kms"; then |
This comment has been minimized.
This comment has been minimized.
psyke83
Nov 11, 2019
Member
Can you change this to mesa, please?
IMHO, usage of the kms platform flag should be architecture-agnostic when possible due to the fact that any modern system is potentially capable of running in KMS mode. Your PR runs fine on x86 kms mode with the flag changed to mesa (whereas the PR breaks the x86 kms build as-is). Thanks.
This comment has been minimized.
This comment has been minimized.
joolswills
force-pushed the
joolswills:lr-parallel-n64_fix
branch
4 times, most recently
from
c186d53
to
b943229
* added libgles2-mesa-dev dependency for kms+gles platforms * remove a typedef conflict - may need to upstream a proper fix for this * rework Makefile parameter logic based on our platform flags
joolswills
force-pushed the
joolswills:lr-parallel-n64_fix
branch
from
b943229
to
8ffd03e
This comment has been minimized.
This comment has been minimized.
|
Merging but this may need further platform logic tweaks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
joolswills commentedNov 1, 2019
I've not tested this at all apart from building on rpi2 and rpi4. Need to check the typedef change on tinkerboard. Probably should be upstreamed but upstream master is broken on arm which also needs fixing.