Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ps3 to platforms #2911

Closed
wants to merge 1 commit into from
Closed

Add ps3 to platforms #2911

wants to merge 1 commit into from

Conversation

@raelgc
Copy link
Contributor

raelgc commented Dec 3, 2019

This will allow future setup scripts to easily add PS3 in es_systems.cfg.

This will allow future custom scripts to easily add PS3 in es_systems.cfg
@joolswills

This comment has been minimized.

Copy link
Member

joolswills commented Dec 3, 2019

Sorry, but I won't be adding this until we have a ps3 emulator included.

@raelgc

This comment has been minimized.

Copy link
Contributor Author

raelgc commented Dec 3, 2019

Well, I tried with #2905, using the app image provided by rpcs3 team :)

@joolswills

This comment has been minimized.

Copy link
Member

joolswills commented Dec 3, 2019

We will consider adding ps3 when we are ready. I wasn't happy with your solution, and we have other priorities currently.

@joolswills joolswills closed this Dec 3, 2019
@joolswills

This comment has been minimized.

Copy link
Member

joolswills commented Dec 3, 2019

We work on this in our spare time. We are not obligated to add every feature / pull request that is submitted.

@raelgc

This comment has been minimized.

Copy link
Contributor Author

raelgc commented Dec 3, 2019

@joolswills Sorry, my intent was not be aggressive. I'm fine with you closing my contributions (it's not my contribution to Retropie) and I like how you keep your focus on project goals.

I just opened this one because you said that people probably will manually add rpcs3 manually to the platform. This PR will just avoid people have to manually edit es_systems.cfg.

But, like I've said, I'm fine if you don't want it now.

@joolswills

This comment has been minimized.

Copy link
Member

joolswills commented Dec 3, 2019

They can create a local platforms.cfg with the entry in /opt/retropie/configs/all/platforms.cfg which is the best bet if manually adding modules.

@joolswills

This comment has been minimized.

Copy link
Member

joolswills commented Dec 3, 2019

No worries - just that you wrote "Sorry to insist on this one:" on the PR and wanted to be clear that's not how it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.