Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system - added recognition for Jetson Nano and Tegra X1 #3222

Merged
merged 1 commit into from Sep 13, 2020
Merged

system - added recognition for Jetson Nano and Tegra X1 #3222

merged 1 commit into from Sep 13, 2020

Conversation

joolswills
Copy link
Member

  • by user request - not officially supported

@joolswills joolswills mentioned this pull request Sep 12, 2020
Closed
joolswills
joolswills commented Sep 12, 2020
View reviewed changes
scriptmodules/system.sh Outdated
"NVIDIA Jetson Nano Developer Kit")
__platform="jetson-nano"
;;
*icosa*)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't sure if this was requiring a partial match or not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be icosa and that's it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove the wildcards

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@joolswills
Copy link
Member Author

This is hardcoded for only aarch64 for these boards btw. I don't have anything to test with. If there's more arm x11 + GL boards I may rework it somewhat. I have plans to split out the systems configs after more refactoring anyway.

@theofficialgman
Copy link
Contributor

theofficialgman commented Sep 12, 2020 •
edited

nvidia renames the model if its not a tegra x1 so there shouldn't be any worry of it not being aarch64

@joolswills
Copy link
Member Author

Thanks. Please let me know if this works and I'll merge it.

@theofficialgman
Copy link
Contributor

Just finished testing your latest changes (37c14a2) and built a system that it compatible (lr-parallel-n64). Seems to work as expected.

@joolswills
system - added recognition for Jetson Nano and Tegra X1
bb92cfb 
 * by user request - not officially supported
@joolswills
Copy link
Member Author

I just made one further change. Since they both share the same platform specs as far as we are concerned, I made the jetson nano share the tegra-x1 platform config. Just a bit of deduplication

@joolswills
Copy link
Member Author

Thanks. My last change shouldn't affect anything so I'll merge in a bit.

@theofficialgman
Copy link
Contributor

that's fine. jetson nano really only differs in number of gpu cuda cores which isn't affected here

@joolswills
Copy link
Member Author

Interesting. I know very little about these systems. Maybe I should get a second hand switch to have a play.

@theofficialgman
Copy link
Contributor

theofficialgman commented Sep 13, 2020 •
edited

you have to get an original switch model (not the new switch) since you can't hack those without modchips. We would be welcome to have you at switchroot

@joolswills joolswills merged commit 69add6c into RetroPie:master Sep 13, 2020
@joolswills joolswills deleted the jetson-nano_and_tegra-x1 branch June 25, 2021 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theofficialgman theofficialgman theofficialgman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joolswills @theofficialgman