Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

added integer display option, very useful for gpi/pi-zero. #8

Open
wants to merge 2 commits into
base: master
from

Conversation

@DSkywalk
Copy link

commented Aug 29, 2019

Hi this PR add a pixel perfect correction option to user CFG.

imagen

thanks 馃憤

@DSkywalk

This comment has been minimized.

Copy link
Author

commented Sep 11, 2019

Sorry Hugo ( @hhromic ), we meet in this PR from libretro.

could someone from retropie review these PRs?

Please check, the other PR on mame4all: RetroPie/mame4all-pi#14

It would be great see this options available /officially/ 馃憤
It looks great on little LCD screens! 馃拑

Really thanks :)

@hhromic

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

Hi @DSkywalk , no problem at all with pinging.
I will ask around the devs about these PRs as I'm not very familiar with these emulators.
I assume you tested your contributions thoroughly before submitting right?
They look good.

@DSkywalk

This comment has been minimized.

Copy link
Author

commented Sep 11, 2019

Yeah, these PRs just add a new option to removing any image-stretch.

And yes is tested a lot! We are using it (with some other guys in Telegram and reddit) from the first day I implemented it 馃帀
Is retropie open to new features or you preffer do not touch your ports? I do not want to disturb.

thanks again @hhromic :)

printf("integer enabled - %ux%u : %ux%u (x:%f y:%f)\n",
display_width, display_height, bitmap_width, bitmap_height, sx, sy);
}
else
{

This comment has been minimized.

Copy link
@joolswills

joolswills Sep 12, 2019

Member

I think the original indentation is somewhat wonky but can you align this as the original and we can reformat later if needed. Thanks.

This comment has been minimized.

Copy link
@DSkywalk

DSkywalk Sep 12, 2019

Author

Sorry, my english is terrible, you preffer printf in just one line?
I usually try to adapt my code to 80cols, but no problem.

I fixed some missing tabs in my code, thanks @joolswills

@DSkywalk

This comment has been minimized.

Copy link
Author

commented Sep 12, 2019

Oh, sorry!
the PR is already merged, sorry for the new changes. Just fixed some tabs.

@hhromic

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

This PR still open :)
Thanks @DSkywalk for your contributions, appreciated!

@hhromic

This comment has been minimized.

Copy link
Member

commented Sep 13, 2019

@DSkywalk is this PR ready to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.