New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: sixad: improve coexistence of first & third-party controllers #19

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@psyke83

psyke83 commented Jan 10, 2018

Remove GASIA_GAMEPAD_HACKS macro and use the appropriate
configuration based on each detected controller instead.

--

Don't merge; needs testing by owners of third-party controllers such as @pjft.

The intent of this PR is to eliminate the need for separate branches, so when testing this PR, please install using the first option of the scriptmodule (so it fetches the master branch, that this PR affects). If the patch works well, I'll send a PR to clean up the scriptmodule afterwards.

@joolswills

This comment has been minimized.

Show comment
Hide comment
@joolswills

joolswills Jan 10, 2018

Member

Thanks for this - it will be much more manageable with a single branch to maintain.

Member

joolswills commented Jan 10, 2018

Thanks for this - it will be much more manageable with a single branch to maintain.

Show outdated Hide outdated bluetooth.cpp Outdated
@psyke83

This comment has been minimized.

Show comment
Hide comment
@psyke83

psyke83 Jan 11, 2018

I updated the PR:

  • added a small function that queries the remote name of the controller to help detect the difference between official, gasia and shanwan controllers.
  • get_sdp_device_info() is called only for official controllers, and the manual configuration fallback is used for both shanwan and gasia.
  • the gasia-specific configuration will no longer be used on Shanwan controllers (not sure if this is the ideal behaviour until it's tested)

To help troubleshoot, the function will print the name of the controller in the log, like so:

Jan 11 01:57:09 retropie-test sixad-bin[19566]: remote name: PLAYSTATION(R)3 Controller

Will add some additional notes inline.

psyke83 commented Jan 11, 2018

I updated the PR:

  • added a small function that queries the remote name of the controller to help detect the difference between official, gasia and shanwan controllers.
  • get_sdp_device_info() is called only for official controllers, and the manual configuration fallback is used for both shanwan and gasia.
  • the gasia-specific configuration will no longer be used on Shanwan controllers (not sure if this is the ideal behaviour until it's tested)

To help troubleshoot, the function will print the name of the controller in the log, like so:

Jan 11 01:57:09 retropie-test sixad-bin[19566]: remote name: PLAYSTATION(R)3 Controller

Will add some additional notes inline.

Show outdated Hide outdated sixaxis.cpp Outdated
Show outdated Hide outdated sixaxis.cpp Outdated
@psyke83

This comment has been minimized.

Show comment
Hide comment
@psyke83

psyke83 Jan 11, 2018

OK, updated the PR to allow shanwan to be exported via arguments and restricted the recv commands to official controllers only. Apologies for the spam; will leave the PR alone until I get feedback.

psyke83 commented Jan 11, 2018

OK, updated the PR to allow shanwan to be exported via arguments and restricted the recv commands to official controllers only. Apologies for the spam; will leave the PR alone until I get feedback.

@pjft

This comment has been minimized.

Show comment
Hide comment
@pjft

pjft Jan 11, 2018

Not at all, thanks for all the work here and for the updates. I didn't have time to check this yesterday but will try to do it this evening.

Have a great day!

pjft commented Jan 11, 2018

Not at all, thanks for all the work here and for the updates. I didn't have time to check this yesterday but will try to do it this evening.

Have a great day!

sixad: improve coexistence of first & third-party controllers
Remove GASIA_GAMEPAD_HACKS macro and use the appropriate
configuration based on each detected controller instead.
@psyke83

This comment has been minimized.

Show comment
Hide comment
@psyke83

psyke83 Jan 25, 2018

Closing this as the backported hid-sony & BlueZ is a preferable solution.

psyke83 commented Jan 25, 2018

Closing this as the backported hid-sony & BlueZ is a preferable solution.

@psyke83 psyke83 closed this Jan 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment