Update with GSoC progress #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
login.js when used as a module works as a mithril component that renders a login page and communicates with RS Json API to faciliate validation. Also updated qmake file to include login.js in build.
Added extra function to verify API keys(to be used by login.js) and updated HTTP requests function to use a different callback on failiure.
index.html's initial startpoint now loads all pages using mithril's route functionality. And changed downloads.js to disable updating of downloads list before the keys have been verified.
Communication with Json API now only happens if the keys are verified. Automatic rendering and reloading of downloads is handled by oninit attribute of the downloads component.
Due to security and debugging issues, the minified version will not be used in the build process anymore. The framework is pretty minimalistic so it would not make that big of a difference.
Previously, the downloads page would be loaded but API would not be accessed. This was causing issues with mithril's auto rendering. Not loading the downloads component will make sure no requests are being sent before login finishes.
rsJsonApiRequest() will use m.request instead of XmlHttpRequest for all xhr requests to retroshare client. m.request makes it possible to notify mithril's DOM vnodes on response and returns a Promise for easier async calls.
Login specific functionality like authentication and reporting moved to login.js script.
The starting point of the app moved from html file to main.js.
Created home tabe which displays user's certificate.
Added new files main.js and home.js to webui.pro
The existing css has been disabled for the moment and a new css file theme.css has been created. Respective components modified to reflect changes for css selectors.
Functions used by downloads component for
Functions used by downloads component to load and store files list have been moved from rswebui.js to downloads.js. And added theme for the widgets in downloads page.
background tasks can be initiated from rswebui.js, Downloads component will automatically update the file list whenever it is mounted.
resume/pause and cancel buttons on file transfers fixed and now work as expected.
Config tab will be used to display node details and settings/configuration options for both RS and the WebUI.
Display public information(from preferences>Node in RS).
Panel members in Config panel can be created, controlled and derived by using Panel class.
Shows Info about own services: names, type, version.
The 'general' panel in config tab is renamed to 'network' panel. Added options to set maximum upload and download limits.
The chat api uses 64 bit int to represent ids, which is bigger than JS max int limit. Hence the chat component requires use of custom Serializer and Deserializer to overcome this limit and store ids as string.
Fixed bug where the same location would appear multiple times in network tab.
xhr.responseText is a getter only property and causes an error when modified. A separate variable will be used instead.
oninit of people resolver will directly point to model method.
csoler
reviewed
Aug 22, 2019
webui-src/app/mail/mail_resolver.js
Outdated
| // RS_MSG_BOXMASK = 0x000f | ||
| // RS_MSG_INBOX | ||
| Messages.inbox = Messages.all.filter( | ||
| (msg) => (msg.msgflags & 0x000f) === 0); |
There was a problem hiding this comment.
Would be better to have constants with names that match the constants in rsmsgs.h instead of blind numbers (1,3,5, etc).
csoler
reviewed
Aug 22, 2019
webui-src/app/mail/mail_util.js
Outdated
| }, (data) => { | ||
| details = data.msg; | ||
| files = details.files; | ||
| isStarred = (details.msgflags & 0xf00) === 0x200; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created login page using mithril.js as part of task 101 of the project.