{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":596303168,"defaultBranch":"main","name":"rc-injector","ownerLogin":"RevenueCat","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2023-02-01T22:19:29.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/33013347?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1705415409.0","currentOid":""},"activityList":{"items":[{"before":"9161ff512df5f2844bc48323ab224c9ddd37745c","after":"7db747b039ddf6d826cd51eb44495cdb37e37e41","ref":"refs/heads/main","pushedAt":"2023-03-24T11:17:10.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bisho","name":null,"path":"/bisho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1917?s=80&v=4"},"commit":{"message":"Fix injector races (#4)\n\n* Fix injector races\r\n\r\n## Motivation / Description\r\nIdeally the injector is used only once to build the Server class\r\nwith all its dependencies. But if used in concurrency we can't\r\nhave a shared stack or can lead to races and all short of issues.\r\n\r\n## Changes introduced\r\n- Split the context into a class we create for each instantiation\r\n  so we can avoid races between concurrent `injector.get()` calls.\r\n- Add a fast-path for cached instances, so we don't build a context\r\n  object for things already built.\r\n\r\n* bump version to 0.0.2\r\n\r\n* Add test\r\n\r\nBefore the fix, the test was causing\r\n```\r\nE           rc_injector.injector.CircularDependencyError: Unable to instantiate <class 'tests.injector_test.test_concurrent_injection.<locals>.A'> because <class 'tests.injector_test.test_concurrent_injection.<locals>.A'> causes a circular dependency. To build it, ultimately <class 'tests.injector_test.test_concurrent_injection.<locals>.A'> is needed that needs <class 'tests.injector_test.test_concurrent_injection.<locals>.A'> again. Dependency stack is: [<class 'tests.injector_test.test_concurrent_injection.<locals>.A'>]\r\n```\r\n\r\nNow it works","shortMessageHtmlLink":"Fix injector races (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1639180069\" data-permission-text=\"Title is private\" data-url=\"https://github.com/RevenueCat/rc-injector/issues/4\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/RevenueCat/rc-injector/pull/4/hovercard\" href=\"https://github.com/RevenueCat/rc-injector/pull/4\">#4</a>)"}},{"before":"54e81d2ec52cde9edf4e1aca5f442e2b7b6f3952","after":"f21b3d53aa8cfdb449abe116ddb021a2c243a197","ref":"refs/heads/fix_races","pushedAt":"2023-03-24T11:16:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bisho","name":null,"path":"/bisho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1917?s=80&v=4"},"commit":{"message":"Add test\n\nBefore the fix, the test was causing\n```\nE           rc_injector.injector.CircularDependencyError: Unable to instantiate <class 'tests.injector_test.test_concurrent_injection.<locals>.A'> because <class 'tests.injector_test.test_concurrent_injection.<locals>.A'> causes a circular dependency. To build it, ultimately <class 'tests.injector_test.test_concurrent_injection.<locals>.A'> is needed that needs <class 'tests.injector_test.test_concurrent_injection.<locals>.A'> again. Dependency stack is: [<class 'tests.injector_test.test_concurrent_injection.<locals>.A'>]\n```\n\nNow it works","shortMessageHtmlLink":"Add test"}},{"before":null,"after":"54e81d2ec52cde9edf4e1aca5f442e2b7b6f3952","ref":"refs/heads/fix_races","pushedAt":"2023-03-24T11:01:14.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"bisho","name":null,"path":"/bisho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1917?s=80&v=4"},"commit":{"message":"bump version to 0.0.2","shortMessageHtmlLink":"bump version to 0.0.2"}},{"before":"f2862703b348a6ec2db4d57bd29cadcc2f2d3216","after":"9161ff512df5f2844bc48323ab224c9ddd37745c","ref":"refs/heads/main","pushedAt":"2023-03-21T13:38:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bisho","name":null,"path":"/bisho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1917?s=80&v=4"},"commit":{"message":"Create .github/dependabot.yml","shortMessageHtmlLink":"Create .github/dependabot.yml"}},{"before":null,"after":"e9303ff2cbc87ac18020206149b3be371a3573a4","ref":"refs/heads/readme-fix-typos","pushedAt":"2023-03-15T10:26:42.702Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"swehner","name":null,"path":"/swehner","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/273236?s=80&v=4"},"commit":{"message":"Update README.md\n\nFix some typos","shortMessageHtmlLink":"Update README.md"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADCnanewA","startCursor":null,"endCursor":null}},"title":"Activity · RevenueCat/rc-injector"}