Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Write comments and have discussion about Notebook contents #1
Visual diff is great. But when a user looks at it, the next logical step is to provide some feedback or ask clarifying questions to author. These could be higher level questions about approach/algorithm or more specific questions about code/output.
This is currently done via chat tool (slack etc.) which doesn't have the Notebook context (which cell are you talking about). Or it's done on the call or face to face with the Notebook open in the front. That way it becomes a synchronous process (requires scheduling a meeting) and discussion isn't captured anywhere.
Proposal to Solve
Ability to comment can very well integrate into ReviewNb visual diffs. Take a look at the picture below.
Feel free to upvote/downvote the issue indicating whether you think this is useful feature or not. I also welcome additional questions/comments/discussion on the issue.