New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write comments and have discussion about Notebook contents #1

amit1rrr opened this Issue Oct 23, 2018 · 1 comment


None yet
2 participants

amit1rrr commented Oct 23, 2018


Visual diff is great. But when a user looks at it, the next logical step is to provide some feedback or ask clarifying questions to author. These could be higher level questions about approach/algorithm or more specific questions about code/output.

This is currently done via chat tool (slack etc.) which doesn't have the Notebook context (which cell are you talking about). Or it's done on the call or face to face with the Notebook open in the front. That way it becomes a synchronous process (requires scheduling a meeting) and discussion isn't captured anywhere.

Proposal to Solve

Ability to comment can very well integrate into ReviewNb visual diffs. Take a look at the picture below.

screenshot 2018-10-23 at 5 35 51 pm


  • Comments have the context of Notebook cells to which they apply
  • Collaboration workflow becomes asynchronous as opposed to meetings/calls etc.
  • The discussion is captured and can be used for reference in future.

Feel free to upvote/downvote the issue indicating whether you think this is useful feature or not. I also welcome additional questions/comments/discussion on the issue.

@amit1rrr amit1rrr self-assigned this Oct 23, 2018


This comment has been minimized.

mirestrepo commented Dec 5, 2018

We'd love to use this feature in a classroom setting as a way to provide feedback to students.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment