Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make review comments apply to a range of lines #83

Closed
jdm opened this issue Apr 20, 2015 · 1 comment
Closed

Make review comments apply to a range of lines #83

jdm opened this issue Apr 20, 2015 · 1 comment

Comments

@jdm
Copy link

jdm commented Apr 20, 2015

I often provide review comments that apply to a number of contiguous lines. It would be much clearer if I could select them and show that the comment applies to all of them, like https://critic.hoppipolla.co.uk/showcomment?chain=8508 for example.

@pkaminski
Copy link
Member

I considered this early on, but decided that the potential bump in clarity is not worth the extra UX complexity. For the rare cases where a line range is important it's possible to just describe it in the comment instead. At this point, the assumption that a discussion is attached to a single line is baked too deeply into the code, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants