New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing #271 #272

Merged
merged 2 commits into from Jan 26, 2018

Conversation

Projects
None yet
3 participants
@samalero
Contributor

samalero commented Jan 25, 2018

  • This PR actually submits something - don't use this system as a messaging service!
  • This PR isn't duplicated - you can check if it is by scanning the small list - link is on the navigation bar for this repository.
  • This PR includes appropriate markdown for sections - e.g. code blocks for suggested code.
  • This PR description and comments in code is understandable - feel free to use your native language to write if you are not comfortable with English.
  • This PR has a single branch for itself in your fork - don't just commit to the master branch of your repository!
  • This PR has comments written in clear English - please don't write unreadable comments just for your eyes.

Pull Request description

Fix issue #271

Changed Branch

master

Optional information

...

samalero added some commits Jan 25, 2018

@95CivicSi

This comment has been minimized.

Collaborator

95CivicSi commented Jan 25, 2018

Thanks for your submission @samalero. The updates look like they will silence the errors. I need to test this and make sure there are no lingering problems.

@95CivicSi 95CivicSi self-requested a review Jan 25, 2018

@jasonwynn10

This comment has been minimized.

jasonwynn10 commented on 506c0a2 Jan 25, 2018

That’s not how PHP works... the return type needs to be ?string to be nullable

@95CivicSi

This comment has been minimized.

Collaborator

95CivicSi commented Jan 26, 2018

@jasonwynn10 that was fixed in 98dd5af

@95CivicSi 95CivicSi merged commit 56f715d into RevivalPMMP:master Jan 26, 2018

1 check passed

poggit-ci/pureentitiesx Created PR build #69 (&34795): lint passed
Details

@samalero samalero deleted the samalero:patch-1 branch Jan 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment