Skip to content
This repository has been archived by the owner. It is now read-only.

XP Overhaul #275

merged 2 commits into from Feb 4, 2018

XP Overhaul #275

merged 2 commits into from Feb 4, 2018


Copy link

@95CivicSi 95CivicSi commented Jan 30, 2018

  • This PR actually submits something - don't use this system as a messaging service!
  • This PR isn't duplicated - you can check if it is by scanning the small list - link is on the navigation bar for this repository.
  • This PR includes appropriate markdown for sections - e.g. code blocks for suggested code.
  • This PR description and comments in code is understandable - feel free to use your native language to write if you are not comfortable with English.
  • This PR has a single branch for itself in your fork - don't just commit to the master branch of your repository!
  • This PR has comments written in clear English - please don't write unreadable comments just for your eyes.

Pull Request description

This will directly change how PureEntitiesX will utilize experience. This off loads the work of calculating XP for users and handling XP orb entities on to the core server software. this happens by removing all XP calculation code and relying on PocketMine-MP's new experience API. Additionally entities were updated to utilize the same API. this will not change the behavior of entities that previously did not drop experience. That update is expected to happen at a later time.

Changed Branch


Optional Information

While initial testing shows that this update should be completely stable, it still needs further evaluation and testing from members of the community. Please download the existing build on Poggit, that corresponds with this pull request.

95CivicSi added 2 commits Jan 28, 2018
…entities to use getXpDropAmount(). As xp is now provided by the core, it is currently not able to be turned off.
@95CivicSi 95CivicSi requested a review from jasonwynn10 Jan 31, 2018
@95CivicSi 95CivicSi self-assigned this Jan 31, 2018
@95CivicSi 95CivicSi merged commit f5830db into master Feb 4, 2018
1 check passed
1 check passed
poggit-ci/pureentitiesx Created PR build #70 (&35234): Lint passed
@95CivicSi 95CivicSi deleted the XP-Overhaul branch Feb 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant