New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API to 3.0.X and some cleanup. #315

Merged
merged 36 commits into from Jun 27, 2018

Conversation

Projects
None yet
3 participants
@95CivicSi
Collaborator

95CivicSi commented Jun 27, 2018

  • This PR actually submits something - don't use this system as a messaging service!
  • This PR isn't duplicated - you can check if it is by scanning the small list - link is on the navigation bar for this repository.
  • This PR includes appropriate markdown for sections - e.g. code blocks for suggested code.
  • This PR description and comments in code is understandable - feel free to use your native language to write if you are not comfortable with English.
  • This PR has a single branch for itself in your fork - don't just commit to the master branch of your repository!
  • This PR has comments written in clear English - please don't write unreadable comments just for your eyes.

Pull Request description

This PR will bring PureEntitiesX into compatibility with the API for PocketMine-MP v3.0.X while maintaining a similar experience as the current version.

Changed Branch

Large numbers of updates were included to be compatible with the new API.

  • Multiple entity method refactors to add return types.
  • Imports were optimized to remove unused imports from some files.
  • Updated Scheduler usages.
  • Update Biome namespaces.
  • Updated Spawner for Tile NBT updates.
  • Fix missed conversion of individual motion coordinates to Vector3 in FlyingEntity.
  • Remove Rabbit test class under Jumping

Additional changes can be identified by their commit messages.

Optional information

...

95CivicSi added some commits Jun 16, 2018

@ZizzyZizzy

This comment has been minimized.

ZizzyZizzy commented on 559194d Jun 18, 2018

Now something else is broken:

fatal error: Declaration of revivalpmmp\pureentities\entity\BaseEntity::initEntity() must be compatible with pocketmine\entity\Living::initEntity(): void in phar:///plugins/PureEntitiesX.phar/src/revivalpmmp/pureentities/entity/BaseEntity.php on line 528

This comment has been minimized.

Collaborator

95CivicSi replied Jun 18, 2018

This update is not finished yet. Still lots to do before a compatible version is released for 3.0.0

This comment has been minimized.

ZizzyZizzy replied Jun 18, 2018

I can only imagine. The API changes more often than underwear does around here...

@95CivicSi 95CivicSi requested a review from jasonwynn10 Jun 27, 2018

@95CivicSi 95CivicSi self-assigned this Jun 27, 2018

@@ -20,7 +20,8 @@
namespace revivalpmmp\pureentities\data;
use pocketmine\level\generator\biome\Biome;

This comment has been minimized.

@jasonwynn10

jasonwynn10 Jun 27, 2018

Member

unnecessary space

@95CivicSi 95CivicSi merged commit af77ad4 into master Jun 27, 2018

2 checks passed

poggit-ci/PureEntitiesX Created Dev build #253 (&44827): Lint passed
Details
poggit-ci/pureentitiesx Created PR build #86 (&44828): Lint passed
Details

@95CivicSi 95CivicSi deleted the Update-to-3.0.0 branch Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment