Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Patch 1 #117

Closed
wants to merge 29 commits into
from

Conversation

Projects
None yet
2 participants

No description provided.

Collaborator

piccolbo commented Jul 24, 2012

No pull request into master please. And no edits to md, you need to edit the Rmd file or it will be overwritten. And no code in the Rmd file, you need to add your code to the test directory and be sure it can run. Lots of requirements, isn't it? (but they are documented, see https://github.com/ryangarner/RHadoop/wiki/Documentation-guidelines-for-rmr). But I really appreciate the contribution and like this additional format example, spot on. If you don't feel like learning Rmd and knitr, I can easily reformat your patch to fit the current documentation workflow and credit you in the comments. Thanks

Sounds good. I will look into your guidelines, Rmd, and knitr.

On Jul 24, 2012, at 12:36 PM, Antonio Piccolboni reply@reply.github.com wrote:

No pull request into master please. And no edits to md, you need to edit the Rmd file or it will be overwritten. And no code in the Rmd file, you need to add your code to the test directory and be sure it can run. Lots of requirements, isn't it? (but they are documented, see https://github.com/ryangarner/RHadoop/wiki/Documentation-guidelines-for-rmr). But I really appreciate the contribution and like this additional format example, spot on. If you don't feel like learning Rmd and knitr, I can easily reformat your patch to fit the current documentation workflow and credit you in the comments. Thanks


Reply to this email directly or view it on GitHub:
#117 (comment)

@ryangarner ryangarner closed this Jul 26, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment