New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove oxygen and CO2 clouds #553

Closed
hhyyrylainen opened this Issue Apr 9, 2018 · 10 comments

Comments

Projects
None yet
3 participants
@hhyyrylainen
Copy link
Contributor

hhyyrylainen commented Apr 9, 2018

As discussed here: https://forum.revolutionarygamesstudio.com/t/compound-rebalancing/386/22 they should be properties of a biome and not individual clouds.

  • Remove the oxygen and CO2 (+ Fatty Acids and Amino Acids) bars from the GUI
  • Add an indicator for environmental oxygen and CO2 to the GUI
  • Add the property to the biome class in c++ and add loading of that property from the json files
  • Put some initial values to the json configuration (it should be scaled so that amount of 1 doesn't affect a process' speed, lower than 1 slows it down and higher than 1 speeds it up, initially the speed could be just multiplied by this if a process needs oxygen or CO2). This means about values of environmental oxygen and co2.
  • MOVED: #570 It should be possible for the cell species to affect the amount of oxygen and CO2 (photosynthesisers)
  • Modify the process system and the compound absorbing / releasing to work with the environmental oxygen and CO2
@TjWhale

This comment has been minimized.

Copy link
Contributor

TjWhale commented Apr 12, 2018

For now lets just remove O2, CO2, Fatty Acids and Amino Acids.

Later we can add global variables in and maybe let cells affect the global variables. Lets just get things balanced first with O2 and CO2 as constants before we start varying them.

@Untrustedlife Untrustedlife modified the milestones: Release 0.4.0, 0.4.1 May 23, 2018

@hhyyrylainen

This comment has been minimized.

Copy link
Contributor

hhyyrylainen commented May 23, 2018

Do you want to split the other points that aren't ticked in the description of this issue to a new issue or how do you consider them being done?

@Untrustedlife

This comment has been minimized.

Copy link
Contributor

Untrustedlife commented May 23, 2018

What i posted is whats left, everything else is done, because i did all that already and its in fix_everything
We could move it to a new issue, but i dont see the point

@Untrustedlife

This comment has been minimized.

Copy link
Contributor

Untrustedlife commented May 23, 2018

I suppose though if it feels like it should be

@hhyyrylainen

This comment has been minimized.

Copy link
Contributor

hhyyrylainen commented May 23, 2018

I edited it to be clear that the config meant about the environmental oxygen levels and also "It should be possible for the cell species to affect the amount of oxygen and CO2 (photosynthesisers)" is perhaps suited to be in a later issue.

@Untrustedlife

This comment has been minimized.

Copy link
Contributor

Untrustedlife commented May 23, 2018

Yeah those values are in the code now, look at the json and look at the biome code.

@Untrustedlife

This comment has been minimized.

Copy link
Contributor

Untrustedlife commented May 23, 2018

it even loads the oxygen and co2 per biome lol

@Untrustedlife

This comment has been minimized.

Copy link
Contributor

Untrustedlife commented Jun 9, 2018

We should add a temperature gauge to the GUI aswell

@Untrustedlife Untrustedlife self-assigned this Jan 5, 2019

@Untrustedlife

This comment has been minimized.

Copy link
Contributor

Untrustedlife commented Jan 5, 2019

I suppose i can tackle this right now.

@Untrustedlife

This comment has been minimized.

Copy link
Contributor

Untrustedlife commented Jan 12, 2019

Fixed in #713

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment