New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make membrane bound organelles locked without a nucleus #679

hhyyrylainen opened this Issue Dec 26, 2018 · 1 comment


None yet
1 participant
Copy link

hhyyrylainen commented Dec 26, 2018

This depends on: #678
Once that is done all the membrane bound organelles should be locked in the editor until the cell has a nucleus.

Also all the old commented out code regarding the floating organelles unlocking things should be finally removed (and the debug print statements that aren't commented out).

@hhyyrylainen hhyyrylainen added this to the 0.4.1 milestone Dec 26, 2018

hhyyrylainen added a commit that referenced this issue Jan 15, 2019

nucleus in editor, locked organelle, gui change #677 #678 #679 (#709)
* nucleus in editor, locked organelle, gui change

* fix function editor

* clang format fix

* fix space at line 196

* fix function onSelectNewOrganelle

from common.isEngine to common.isInEngine

* span space

* second span space

* space in microbe editor

* restore GUI function, update editor function

I restore GUI as was, the check is made inside the listener.

I just notice that the editor if statment wasn't correct,

* fix bracket sapce

* fix some spaces and usless  blank lines

* fixes if statment

remove jquery, use plain javascript

* fix space

* fix brackets

* removed jquery line

* fix clang format line 271

* update check for UpdateGuiButtons function

- button are disabled only if weren't already disabled
- same thing for enabling.

* fix format

* move comment

* Update microbe_editor.mjs

* update comment for select button

* update comment of updateSelectedOrganelle

Better explanation for updateSelectedOrganelle function, introducing the concept of button status made in updateGuiButtons

* delete usless check

delete usless and branch of if statment in updateSelectedOrganelle function

* restore comment

* update functions and gui text

- delete select removed class
- change toltip text according to one more scientifically corret

* restore completly old function

* nucleus button has disabled status

- I just forgot that this could be necessary, so nucleus is prevent to be insert more times by guy, and if bypassed by changing the source code there is still the check in as files

* Nucleus name in editor

- i revert htis changment before commit, my bad.

* Rotation for nucleus organelle.

- In renderHighlightedOrganelle method if organelle that is going to be placed is nucleus rotation parameter change to 180 degrees.

- in _addOrganelle method is rotating again in order to have the same rotation of render.

* Nucleus rotation parameters

- removed manual rotation in
- added one time rotation in

Now nucleus is in right position both for microbe  controleld by IA and player one, without any modification in editor

* clang format fix

* nucleus rotation for npc

I do not why it works, i also try put 180 degreesin that line and in inserLast organelle few lines later another 180 and i obtain same result

* editor name

This comment has been minimized.

Copy link

hhyyrylainen commented Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment