Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organelle rotation in the editor is now weird #816

Closed
hhyyrylainen opened this issue Sep 14, 2019 · 8 comments · Fixed by #932
Closed

Organelle rotation in the editor is now weird #816

hhyyrylainen opened this issue Sep 14, 2019 · 8 comments · Fixed by #932
Labels
bug intermediate modelling programming

Comments

@hhyyrylainen
Copy link
Member

Related to: #813
rotating organelles is a bit weird now in the editor, probably another issue with the rotation code, likely similar to what causes the flagella to be weird.
@hhyyrylainen hhyyrylainen added this to the Release 0.4.2 milestone Sep 14, 2019
@Untrustedlife
Copy link
Contributor

Ill grab this as my first pr after awhile

@Untrustedlife Untrustedlife self-assigned this Sep 14, 2019
@hhyyrylainen
Copy link
Member Author

The latest branch is https://github.com/Revolutionary-Games/Thrive/tree/patches

@Untrustedlife
Copy link
Contributor

Not master?

@hhyyrylainen
Copy link
Member Author

Actually, I think the organelle rotation changes are there too... yeah, please ignore.

@Untrustedlife
Copy link
Contributor

I fixed the rotations, the offset is still a little bit wrong but I improved it significantly

@Untrustedlife
Copy link
Contributor

#818

@Untrustedlife Untrustedlife mentioned this issue Sep 15, 2019
Merged
@hhyyrylainen
Copy link
Member Author

This was improved by: #818 but they are still rotated a bit weird. For example many of the organelles at their default rotation are positioned very differently than once rotated 360 degrees, which is strange.

hhyyrylainen pushed a commit that referenced this issue Sep 19, 2019
@Untrustedlife @hhyyrylainen
#816 fix organelle rotation in editor/game (#818)
c4eba93 
* Single hex works fine and editor rotation works,

* "fixed flagella"

* Actually fixed flagella

* Fixed Offset A little bit (Its still about half a hex off)

* formatted

* "its fixed" but the mitochondria and such arent rotated the way i would prefer, also the offset for flagella is still there

* fixed derp

* did what hhenri suggested

* fixed a thing

* did hhenri suggestions

* moved offset delcaration

* Ran formatting
@hhyyrylainen hhyyrylainen removed this from the Release 0.4.2 milestone Sep 23, 2019
@hhyyrylainen hhyyrylainen added this to the Release 0.4.3 milestone Oct 5, 2019
@hhyyrylainen
Copy link
Member Author

@Untrustedlife will you work more on this or can I clear you being assigned?

@hhyyrylainen hhyyrylainen removed this from the Release 0.4.3 milestone Dec 20, 2019
GatoCreador887 added a commit that referenced this issue Jan 18, 2020
@GatoCreador887
Fix odd organelle rotation
94d89f2 
`organelle_component.as L30` was previously violated by the editor code.
Close #816.
@GatoCreador887 GatoCreador887 mentioned this issue Jan 18, 2020
Merged
hhyyrylainen pushed a commit that referenced this issue Jan 18, 2020
@GatoCreador887 @hhyyrylainen
Fix odd organelle rotation (#932)
8b3e295 
`organelle_component.as L30` was previously violated by the editor code.
Close #816.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug intermediate modelling programming
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix odd organelle rotation Revolutionary-Games/Thrive
2 participants
@hhyyrylainen @Untrustedlife