New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dynamic MP logic a bit #3641
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhyyrylainen
reviewed
Aug 4, 2022
hhyyrylainen
reviewed
Aug 9, 2022
hhyyrylainen
reviewed
Aug 9, 2022
Co-authored-by: Henri Hyyryläinen <hhyyrylainen@revolutionarygamesstudio.com>
Co-authored-by: Henri Hyyryläinen <hhyyrylainen@revolutionarygamesstudio.com>
hhyyrylainen
reviewed
Aug 9, 2022
hhyyrylainen
reviewed
Aug 9, 2022
Co-authored-by: Henri Hyyryläinen <hhyyrylainen@revolutionarygamesstudio.com>
hhyyrylainen
reviewed
Aug 9, 2022
|
I just playtested this and it seems to not at least break anything in a major way so once the code is cleaned up a bit I think this can be merged. |
hhyyrylainen
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(This is added because the complexity of Dyn MP.)
Previously, Dyn MP uses a way similar to bubble sort to check if the action data can be merged together. Which means:
May be merged into
This PR aims to make combine operation more optimal by adding a key function
GetLeastCostCombineTuple.Given the data to combine and a list of actions that may be combined to, this function calculates the cost saved by combination for each action and picks the one that saves the most. Then it returns some relevant info.
Related Issues
Extensive testing is needed to prove if this fixes #3558
Workaround #3661
Progress Checklist
Note: before starting this checklist the PR should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.