Jump to conversation
Unresolved conversations (0)
Nice work!

Nice work!

All of your conversations have been resolved.

Resolved conversations (6)
@hhyyrylainen hhyyrylainen Aug 9, 2022
`FindCheapestActionToCombineWith` I think a name like that would make this clearer as to what this does.
Outdated
...crobe_stage/editor/EditorActionHistory.cs
84634E1A607A
@hhyyrylainen hhyyrylainen Aug 9, 2022
```suggestion /// Finds the way to combine an action with previous actions so that the maximum amount of MP is saved. ```
Outdated
...crobe_stage/editor/EditorActionHistory.cs
@hhyyrylainen hhyyrylainen Aug 9, 2022
I'm a bit suspicious about the cast here. What guarantees this doesn't fail?
...crobe_stage/editor/EditorActionHistory.cs
hhyyrylainen 84634E1A607A
@hhyyrylainen hhyyrylainen Aug 9, 2022
```suggestion /// <param name="previousData">A list of data <see cref="currentData"/> may combine with</param> ```
Outdated
...crobe_stage/editor/EditorActionHistory.cs
@hhyyrylainen hhyyrylainen Aug 9, 2022
```suggestion // If mode is the following, no more checks are needed. ```
Outdated
...crobe_stage/editor/EditorActionHistory.cs
@hhyyrylainen hhyyrylainen Aug 4, 2022
```suggestion GetLeastCostCombinedTuple(EditorCombinableActionData currentData, ```
Outdated
...crobe_stage/editor/EditorActionHistory.cs
84634E1A607A hhyyrylainen