New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check brctl command is available (resolves GH#1115) #1147

Merged
merged 1 commit into from Sep 29, 2017

Conversation

Projects
None yet
2 participants
@perlancar
Contributor

perlancar commented May 30, 2017

No description provided.

@krimdomu

This comment has been minimized.

Show comment
Hide comment
@krimdomu

krimdomu Jul 21, 2017

Contributor

Hi @perlancar

thanks for the patch, but i think this would break execution. If brctl is not available, this would stop execution instead of just having no information about the bridges.

So i think, to solve #1115 it would be better to just return an empyt hashref.

Contributor

krimdomu commented Jul 21, 2017

Hi @perlancar

thanks for the patch, but i think this would break execution. If brctl is not available, this would stop execution instead of just having no information about the bridges.

So i think, to solve #1115 it would be better to just return an empyt hashref.

@krimdomu krimdomu added this to the 1.6.0 milestone Sep 29, 2017

@krimdomu krimdomu merged commit 0392f29 into RexOps:development-1.x Sep 29, 2017

@krimdomu

This comment has been minimized.

Show comment
Hide comment
@krimdomu

krimdomu Sep 29, 2017

Contributor

Hi @perlancar

i've just merged this patch to 1.6 line and modified it a bit.

Contributor

krimdomu commented Sep 29, 2017

Hi @perlancar

i've just merged this patch to 1.6 line and modified it a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment