move from @GenerateMicroBenchmark to @Benchmark #1

Merged
merged 3 commits into from Jun 16, 2014

Conversation

Projects
None yet
2 participants
@n0mer
Contributor

n0mer commented Jun 16, 2014

update to jmh v0.9:

  • switch from @generatemicrobenchmark to @benchmark
  • proper package for Result and RunResult classes (w/out "logic" intermediate)
@RichardWarburton

This comment has been minimized.

Show comment
Hide comment
@RichardWarburton

RichardWarburton Jun 16, 2014

Owner

Happy to bump to v0.9 and @benchmark but this doesn't seem to change the pom.xml to a release. Is that right?

Owner

RichardWarburton commented Jun 16, 2014

Happy to bump to v0.9 and @benchmark but this doesn't seem to change the pom.xml to a release. Is that right?

@n0mer

This comment has been minimized.

Show comment
Hide comment
@n0mer

n0mer Jun 16, 2014

Contributor

@RichardWarburton you've been using snapshot dependency, so this is up to you.
I prefer to specify exact version, so please review follow-up comits.

Contributor

n0mer commented Jun 16, 2014

@RichardWarburton you've been using snapshot dependency, so this is up to you.
I prefer to specify exact version, so please review follow-up comits.

@RichardWarburton

This comment has been minimized.

Show comment
Hide comment
@RichardWarburton

RichardWarburton Jun 16, 2014

Owner

I only originally started using a snapshot version in order to bring in a bug fix which wasn't in a public release, now 0.9 is out its great that you've put that in the pom!

Thanks for the pull request, merging now.

Owner

RichardWarburton commented Jun 16, 2014

I only originally started using a snapshot version in order to bring in a bug fix which wasn't in a public release, now 0.9 is out its great that you've put that in the pom!

Thanks for the pull request, merging now.

RichardWarburton added a commit that referenced this pull request Jun 16, 2014

Merge pull request #1 from n0mer/master
move from @GenerateMicroBenchmark to @Benchmark

@RichardWarburton RichardWarburton merged commit 0d5cebc into RichardWarburton:master Jun 16, 2014

@n0mer

This comment has been minimized.

Show comment
Hide comment
@n0mer

n0mer Jun 16, 2014

Contributor

thank you as well for open-sourcing the code!

by the way i found your articles here http://www.javacodegeeks.com/author/richard-warburton/ - thanks for publishing your insights and findings, very informative.

One more contribution: recently found nice article from atlassian on how to use Git (especually this "pull request" functionality) here: https://www.atlassian.com/git/workflows Good link to recommend to your readers when you state that code is on GitHub. I learned how to do "pull requests" and how to deal with forked repositoried from atlassian.

Contributor

n0mer commented Jun 16, 2014

thank you as well for open-sourcing the code!

by the way i found your articles here http://www.javacodegeeks.com/author/richard-warburton/ - thanks for publishing your insights and findings, very informative.

One more contribution: recently found nice article from atlassian on how to use Git (especually this "pull request" functionality) here: https://www.atlassian.com/git/workflows Good link to recommend to your readers when you state that code is on GitHub. I learned how to do "pull requests" and how to deal with forked repositoried from atlassian.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment