New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding double quotes around the NugetExe and $WorkingFolder variables #40

Merged
merged 3 commits into from Oct 2, 2018

Conversation

Projects
None yet
2 participants
@paschott
Contributor

paschott commented Oct 2, 2018

Nuget will not work if the target path has spaces in it without double quotes.

paschott and others added some commits Oct 2, 2018

Adding double quotes around the NugetExe and $WorkingFolder variables
Nuget will not work if the target path has spaces in it without double quotes.
Update InstallMicrosoftDataToolsMsBuild.ps1
making change to kick off pr build
Update InstallMicrosoftDataToolsMsBuild.ps1
Another minor change to trigger build

@RichieBzzzt RichieBzzzt merged commit 64c1ed1 into RichieBzzzt:master Oct 2, 2018

1 check failed

PoshSSDTBuildDeploy-CI #2.0.392.0 failed
Details
@RichieBzzzt

This comment has been minimized.

Show comment
Hide comment
@RichieBzzzt

RichieBzzzt Oct 2, 2018

Owner

Nicely done!

Got pr running off your forked project. It failed on some strangeness but kicked off again from VSTS and all good. Once it's merged I'll write a test around your change.

Owner

RichieBzzzt commented Oct 2, 2018

Nicely done!

Got pr running off your forked project. It failed on some strangeness but kicked off again from VSTS and all good. Once it's merged I'll write a test around your change.

@paschott

This comment has been minimized.

Show comment
Hide comment
@paschott

paschott Oct 2, 2018

Contributor
Contributor

paschott commented Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment