Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting of Typescript dictionary types #1035

Conversation

@ljvanschie
Copy link
Contributor

commented Jul 19, 2019

Small change that updates the formatting of dictionary types in Typescript. Removes the space before the colon. So that code generation changes from

Promise<{ [key: string] : number; }>

to

Promise<{ [key: string]: number; }>

which is more generally accepted and often done by autoformatters.

@RicoSuter

This comment has been minimized.

Copy link
Owner

commented Jul 19, 2019

The tests fail, can you fix them?

@RicoSuter RicoSuter merged commit 3c21467 into RicoSuter:master Jul 19, 2019

1 check passed

NJsonSchema - CI Build #20190719.2 succeeded
Details

@ljvanschie ljvanschie deleted the ljvanschie:fix-typescript-dictionary-type-formatting branch Jul 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.