Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for UrlAttribute, PhoneAttribute, EmailAddressAttribute #963

Merged
merged 1 commit into from May 8, 2019

Conversation

Projects
None yet
2 participants
@vanashimko
Copy link
Contributor

commented May 8, 2019

Add tests to prove that 3 additional items from #182 can be marked as done.

It works since UrlAttribute, PhoneAttribute, EmailAddressAttribute are derived from DataTypeAttribute, which handling is already implemented.

Also small refactoring is done in tests to compact similar ones.

Warning: the file AnnotationsGenerationTests.cs is commited with CRLF into repository, while other files use LF. So it took me some time to stop git from changing back to LF to make diff reasonable. I suppose CRLF's should be fixed separately (if you think it should).

@RicoSuter RicoSuter merged commit 4e2f2bc into RicoSuter:master May 8, 2019

@vanashimko vanashimko deleted the vanashimko:issue-182 branch May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.