Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align with new Microsoft.Extensions.ApiDescription.Client package #2148

Merged
merged 1 commit into from May 6, 2019

Conversation

Projects
None yet
2 participants
@dougbu
Copy link
Contributor

commented May 1, 2019

  • aspnet/AspNetCore#8487
  • NSwag.ApiDescription.Design -> NSwag.ApiDescription.Client
    • match newer Microsoft package and clear way for an NSwag.ApiDescription.Server package
  • @(CurrentServiceFileReference) -> @(CurrentOpenApiReference)
  • remove @(ServiceProjectReference) support; coming in NSwag.ApiDescription.Server package
  • use %(Options) metadata instead of %(GenerateNSwagCSharpOptions) and %(GenerateNSwagTypeScriptOptions)
  • use %(FirstForGenerator) metadata to avoid (some) compilation errors due to duplicate class definitions
  • use supported (LTS) runtime when executing dotnet-nswag.dll
@dougbu

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

@RicoSuter as discussed a few weeks ago…

I'll update this PR once the new package is available on NuGet. But, let's resolve any questions / issues up front.

@RicoSuter

This comment has been minimized.

Copy link
Owner

commented May 3, 2019

@dougbu Looks good to me.

@RicoSuter RicoSuter self-requested a review May 3, 2019

Align with new Microsoft.Extensions.ApiDescription.Client package
- aspnet/AspNetCore#8487
- NSwag.ApiDescription.Design -> NSwag.ApiDescription.Client
  - match newer Microsoft package and clear way for an NSwag.ApiDescription.Server package
- `@(CurrentServiceFileReference)` -> `@(CurrentOpenApiReference)`
- remove `@(ServiceProjectReference)` support; coming in NSwag.ApiDescription.Server package
- use `%(Options)` metadata instead of `%(GenerateNSwagCSharpOptions)` and `%(GenerateNSwagTypeScriptOptions)`
- use `%(FirstForGenerator)` metadata to avoid (some) compilation errors due to duplicate class definitions
- use supported (LTS) runtime when executing `dotnet-nswag.dll`

@dougbu dougbu force-pushed the dougbu:dougbu/new.microsoft.package branch from 4beec64 to e122593 May 6, 2019

@dougbu

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

@RicoSuter this is ready to go. Preview 5 bits are now available on NuGet.org and I used the public version of the Microsoft.Extensions.ApiDescription.Client package while rebasing on your 'master' branch

@RicoSuter RicoSuter merged commit 4439cf2 into RicoSuter:master May 6, 2019

@dougbu dougbu deleted the dougbu:dougbu/new.microsoft.package branch May 6, 2019

@RicoSuter

This comment has been minimized.

Copy link
Owner

commented May 21, 2019

v12.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.