Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net core 3.1 #2567

Merged
merged 3 commits into from Dec 16, 2019
Merged

.Net core 3.1 #2567

merged 3 commits into from Dec 16, 2019

Conversation

@ada3m0n666
Copy link
Contributor

ada3m0n666 commented Dec 5, 2019

just a quick update to get nswag work on .net core 3.1.

@ada3m0n666 ada3m0n666 mentioned this pull request Dec 5, 2019
<file src="..\NSwag.ConsoleCore\bin\release\netcoreapp2.1\Publish\**" target="tools/NetCore21" />
<file src="..\NSwag.ConsoleCore\bin\release\netcoreapp2.2\Publish\**" target="tools/NetCore22" />
<file src="..\NSwag.ConsoleCore\bin\release\netcoreapp3.0\Publish\**" target="tools/NetCore30" />
<file src="..\NSwag.ConsoleCore\bin\release\netcoreapp1.0\**" target="tools/NetCore10" />

This comment has been minimized.

Copy link
@RicoSuter

RicoSuter Dec 5, 2019

Owner

Why no /Publish?

This comment has been minimized.

Copy link
@ada3m0n666

ada3m0n666 Dec 5, 2019

Author Contributor

oh yes sorry. When i try to generate manually nuget package from Nswag.MsBuild it tells me nothing present in /Publish. To get my package quickly i remove /publish. Did not have time to investigate on this sorry.

This comment has been minimized.

Copy link
@ada3m0n666

ada3m0n666 Dec 5, 2019

Author Contributor

to get build.bat works

This comment has been minimized.

Copy link
@RicoSuter

RicoSuter Dec 5, 2019

Owner

strange. But the build is huge and requires some sdks etc

This comment has been minimized.

Copy link
@RicoSuter

RicoSuter Dec 5, 2019

Owner

strange. But the build is huge and requires some sdks etc

This comment has been minimized.

Copy link
@RicoSuter

RicoSuter Dec 5, 2019

Owner

strange. But the build is huge and requires some sdks etc

This comment has been minimized.

Copy link
@RicoSuter

RicoSuter Dec 5, 2019

Owner

strange. But the build is huge and requires some sdks etc

This comment has been minimized.

Copy link
@RicoSuter

RicoSuter Dec 5, 2019

Owner

Will check tomorrow

This comment has been minimized.

Copy link
@ada3m0n666

ada3m0n666 Dec 9, 2019

Author Contributor

i can cancel my changes on /publish if you want.

This comment has been minimized.

Copy link
@RicoSuter

RicoSuter Dec 9, 2019

Owner

Not sure but i think /publish is needed in order that this works correctly.

@RicoSuter

This comment has been minimized.

Copy link
Owner

RicoSuter commented Dec 9, 2019

Please do not upgrade to v13.1.7, I'll to that in another PR.

@bhugot

This comment has been minimized.

Copy link

bhugot commented Dec 9, 2019

@RicoSuter why the solution doesn't use global.json file? would ease the build

@RicoSuter RicoSuter merged commit b23f3c1 into RicoSuter:master Dec 16, 2019
1 check failed
1 check failed
NSwag - CI Build #20191209.2 failed
Details
RicoSuter added a commit that referenced this pull request Dec 16, 2019
Copy link

paulovila left a comment

Looking forward to see the release that supports NetCore3.1

@RicoSuter

This comment has been minimized.

Copy link
Owner

RicoSuter commented Dec 18, 2019

v13.2.0

@RicoSuter

This comment has been minimized.

Copy link
Owner

RicoSuter commented Dec 18, 2019

Please report if its working for you.

@paulovila

This comment has been minimized.

Copy link

paulovila commented Dec 18, 2019

Maybe I don't know how to configure it, the nuget package for nswag.msbuild 13.2.0 doesn't contain the target folder for NetCore3.1, is that still ok? In the msbuild task (csproj), what version should it be used? Maybe I don't know what runtime should I use in the nswag configuration file (runtime:NetCore31)

@RicoSuter

This comment has been minimized.

Copy link
Owner

RicoSuter commented Dec 18, 2019

Then something must be wrong

@RicoSuter

This comment has been minimized.

@paulovila

This comment has been minimized.

Copy link

paulovila commented Dec 19, 2019

In my nuget folder, the nswag.msbuild folder doesn't contain the NetCore3.1 subfolder...,
If you download the nuget package directly and expand the zip file, do you see the NetCore3.1 folder?

@JamesFenton

This comment has been minimized.

Copy link

JamesFenton commented Dec 19, 2019

Looks fine to me (downloaded from nuget.org)

image

image

@paulovila

This comment has been minimized.

Copy link

paulovila commented Dec 19, 2019

Great, I've tried in another pc, and I can see tools/NetCore31 being generated, I'll clear the nuget cache,

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.