Add Ctrl+g and G vim style keybindings to move cursor to first and last line #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rigellute
approved these changes
Nov 6, 2019
| } | ||
| } | ||
|
|
||
| pub fn go_last_line(app: &mut App) { |
There was a problem hiding this comment.
Eventually, we could probably improve things by having a more consistent way of managing the selection index. I'll look into this as part of working on better pagination.
ghost
closed this
ghost
deleted the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I add new keybindings for cursor motion.
ctrl+g and G are Vim-like keybinding that move cursor to first and last line of the list. Real vim keybinding to move cursor to first line is gg but it seems that keybindings that use two or more key are not supported in this app so I assign the fiunction to ctrl+g.
I think that i implemented them in all blocks (Artists, Albums, Playlists and so on) but if you notice my over looking, please tell me it.