Get country from user profile #68
Conversation
svenvNL
force-pushed
the
user-country
branch
2 times, most recently
from
c206d13
to
a8874ce
Compare
There was a problem hiding this comment.
Thanks for taking a crack at this.
I think we could implement this slightly differently, however.
We could store the whole response from current_user in a user prop within app. This would be useful as we could use more user properties for other features.
To not block startup, this request could be made after first render (check line 223 in main.rs).
Do you want to have a go at this? No worries if not.
And if I'm not clear, please give me a shout.
|
@Rigellute Thanks for the feedback! I will change the code tomorrow. |
svenvNL
force-pushed
the
user-country
branch
5 times, most recently
from
2947a56
to
0df2dad
Compare
src/app.rs
Outdated
| Err(e) => { | ||
| self.handle_error(e); | ||
| } | ||
| if let Some(user) = &self.user.to_owned() { |
There was a problem hiding this comment.
To avoid one extra layer of nesting, we could create a tuple and match against that.
e.g.
if let (Some(spotify), Some(user)) = (&self.spotify, &self.user.to_owned()) {
}
src/handlers/input.rs
Outdated
| Ok(result) => { | ||
| app.track_table.tracks = result.tracks.items.clone(); | ||
| app.search_results.tracks = Some(result); | ||
| if let Some(user) = app.user.clone() { |
|
@Rigellute wasn't aware Rust has this syntax available. I have changed the code. |
|
Great work @svenvNL! |
|
@all-contributors please add @svenvNL for code |
|
I've put up a pull request to add @svenvNL! 🎉 |
Country is used by Spotify to determine which songs can be played by an user. By using the country from the users profile, the user does not have to configure it by themselves and the user will not be surprised when a song is not able to play because they have configured another country then in there Spotify account settings.