New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling: more informative crash reports. #1115

Closed
only-a-ptr opened this Issue Sep 8, 2016 · 6 comments

Comments

Projects
None yet
5 participants
@only-a-ptr
Member

only-a-ptr commented Sep 8, 2016

Currently, RoR shows a very raw technical error dialog on crash:
ogreexception---14732089116571435601111

Instead, the dialog should say :

FATAL ERROR

An internal error occured in Rigs of Rods
Technical details below:
Ogre exception blah blah

@only-a-ptr only-a-ptr added this to the 0.4.7.0 milestone Sep 8, 2016

@AnotherFoxGuy

This comment has been minimized.

Show comment
Hide comment
Member

AnotherFoxGuy commented Sep 15, 2016

@AnotherFoxGuy AnotherFoxGuy self-assigned this Sep 15, 2016

@AnotherFoxGuy

This comment has been minimized.

Show comment
Hide comment
@AnotherFoxGuy

AnotherFoxGuy Sep 15, 2016

Member

ror_2016-09-15_09-29-36

Any comments?

Member

AnotherFoxGuy commented Sep 15, 2016

ror_2016-09-15_09-29-36

Any comments?

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Sep 15, 2016

Contributor

Do those wiki pages already exist?

Any comments?

Maybe add an empty line between the first two lines?

Contributor

ulteq commented Sep 15, 2016

Do those wiki pages already exist?

Any comments?

Maybe add an empty line between the first two lines?

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Sep 15, 2016

Member

Let's remove those "you may find help/ URL / open in browser?" features altogether. Those web pages don't exist and we won't create new ones. If the problem is easy to solve, we should tell the player directly in the error message. If not, bummer.

Also, I'd leave only "FATAL ERROR" in the title. The "exception" term is really only meaningful to a developer, and it's already in "technical details below".

Member

only-a-ptr commented Sep 15, 2016

Let's remove those "you may find help/ URL / open in browser?" features altogether. Those web pages don't exist and we won't create new ones. If the problem is easy to solve, we should tell the player directly in the error message. If not, bummer.

Also, I'd leave only "FATAL ERROR" in the title. The "exception" term is really only meaningful to a developer, and it's already in "technical details below".

@Michael10055

This comment has been minimized.

Show comment
Hide comment
@Michael10055

Michael10055 Sep 17, 2016

Contributor

Most of the wiki pages weren't that helpful either, for example: https://xror.avrintech.net/rorwikibackup/index.php/Error_7

Contributor

Michael10055 commented Sep 17, 2016

Most of the wiki pages weren't that helpful either, for example: https://xror.avrintech.net/rorwikibackup/index.php/Error_7

@DarthCainRor

This comment has been minimized.

Show comment
Hide comment
@DarthCainRor

DarthCainRor Sep 19, 2016

As @Michael10055 said, the error message wiki pages where rarely actually helpful, except for error 5 potentially. Which isn't even an issue really anymore with the new Parser, that doesn't crash the game upon loading something with an improperly defined placement line. Most of them were half written, with no real clue on what the actual culprit was.

DarthCainRor commented Sep 19, 2016

As @Michael10055 said, the error message wiki pages where rarely actually helpful, except for error 5 potentially. Which isn't even an issue really anymore with the new Parser, that doesn't crash the game upon loading something with an improperly defined placement line. Most of them were half written, with no real clue on what the actual culprit was.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment